Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1835)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart

Issue 12294028: Fix warnings spotted by dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
index aca3e61781a6d35afb2f7cd16acd7bb0e04dda7d..50acadc6eb1e1f27e95d385873eab700da604fad 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/namer.dart
@@ -323,7 +323,7 @@ class Namer implements ClosureNamer {
!signature.optionalParameters.isEmpty) {
StringBuffer buffer = new StringBuffer();
signature.orderedOptionalParameters.forEach((Element element) {
- buffer.add('\$${safeName(element.name.slowToString())}');
+ buffer.write('\$${safeName(element.name.slowToString())}');
});
methodName = '$methodName$buffer';
}
@@ -362,7 +362,7 @@ class Namer implements ClosureNamer {
assert(name == operatorNameToIdentifier(name));
StringBuffer buffer = new StringBuffer();
for (SourceString argumentName in selector.getOrderedNamedArguments()) {
- buffer.add(r'$');
+ buffer.write(r'$');
argumentName.printOn(buffer);
}
String suffix = '\$${selector.argumentCount}$buffer';
@@ -548,7 +548,7 @@ class Namer implements ClosureNamer {
StringBuffer buffer = new StringBuffer('${element.name.slowToString()}\$');
List<String> names = classes.map((cls) => cls.name.slowToString()).toList();
names.sort();
- names.forEach(buffer.add);
+ names.forEach(buffer.write);
return getMappedGlobalName(buffer.toString());
}

Powered by Google App Engine
This is Rietveld 408576698