Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(83)

Side by Side Diff: dart/sdk/lib/_internal/compiler/implementation/universe/universe.dart

Issue 12294028: Fix warnings spotted by dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library universe; 5 library universe;
6 6
7 import '../closure.dart'; 7 import '../closure.dart';
8 import '../elements/elements.dart'; 8 import '../elements/elements.dart';
9 import '../dart2jslib.dart'; 9 import '../dart2jslib.dart';
10 import '../dart_types.dart'; 10 import '../dart_types.dart';
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 orderedNamedArguments.sort((SourceString first, SourceString second) { 408 orderedNamedArguments.sort((SourceString first, SourceString second) {
409 return first.slowToString().compareTo(second.slowToString()); 409 return first.slowToString().compareTo(second.slowToString());
410 }); 410 });
411 return orderedNamedArguments; 411 return orderedNamedArguments;
412 } 412 }
413 413
414 String namedArgumentsToString() { 414 String namedArgumentsToString() {
415 if (namedArgumentCount > 0) { 415 if (namedArgumentCount > 0) {
416 StringBuffer result = new StringBuffer(); 416 StringBuffer result = new StringBuffer();
417 for (int i = 0; i < namedArgumentCount; i++) { 417 for (int i = 0; i < namedArgumentCount; i++) {
418 if (i != 0) result.add(', '); 418 if (i != 0) result.write(', ');
419 result.add(namedArguments[i].slowToString()); 419 result.write(namedArguments[i].slowToString());
420 } 420 }
421 return "[$result]"; 421 return "[$result]";
422 } 422 }
423 return ''; 423 return '';
424 } 424 }
425 425
426 String toString() { 426 String toString() {
427 String named = ''; 427 String named = '';
428 String type = ''; 428 String type = '';
429 if (namedArgumentCount > 0) named = ', named=${namedArgumentsToString()}'; 429 if (namedArgumentCount > 0) named = ', named=${namedArgumentsToString()}';
(...skipping 101 matching lines...) Expand 10 before | Expand all | Expand 10 after
531 if (cls.isSubclassOf(other)) { 531 if (cls.isSubclassOf(other)) {
532 // Resolve an invocation of [element.name] on [self]. If it 532 // Resolve an invocation of [element.name] on [self]. If it
533 // is found, this selector is a candidate. 533 // is found, this selector is a candidate.
534 return hasElementIn(self, element) && appliesUntyped(element, compiler); 534 return hasElementIn(self, element) && appliesUntyped(element, compiler);
535 } 535 }
536 } 536 }
537 537
538 return false; 538 return false;
539 } 539 }
540 } 540 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698