Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(648)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/dart_types.dart

Issue 12294028: Fix warnings spotted by dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/dart_types.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/dart_types.dart b/dart/sdk/lib/_internal/compiler/implementation/dart_types.dart
index b9bdbd73d903a7da25e4aeba8708a7654d02ec14..f9d0e6952cf85be4466f69f4a854133f963bb4ed 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/dart_types.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/dart_types.dart
@@ -268,17 +268,17 @@ class MalformedType extends DartType {
var sb = new StringBuffer();
if (typeArguments != null) {
if (userProvidedBadType != null) {
- sb.add(userProvidedBadType.name.slowToString());
+ sb.write(userProvidedBadType.name.slowToString());
} else {
- sb.add(element.name.slowToString());
+ sb.write(element.name.slowToString());
}
if (!typeArguments.isEmpty) {
- sb.add('<');
+ sb.write('<');
typeArguments.printOn(sb, ', ');
- sb.add('>');
+ sb.write('>');
}
} else {
- sb.add(userProvidedBadType.toString());
+ sb.write(userProvidedBadType.toString());
}
return sb.toString();
}
@@ -334,11 +334,11 @@ abstract class GenericType extends DartType {
String toString() {
StringBuffer sb = new StringBuffer();
- sb.add(name.slowToString());
+ sb.write(name.slowToString());
if (!isRaw) {
- sb.add('<');
+ sb.write('<');
typeArguments.printOn(sb, ', ');
- sb.add('>');
+ sb.write('>');
}
return sb.toString();
}
@@ -546,40 +546,40 @@ class FunctionType extends DartType {
String toString() {
StringBuffer sb = new StringBuffer();
- sb.add('(');
+ sb.write('(');
parameterTypes.printOn(sb, ', ');
bool first = parameterTypes.isEmpty;
if (!optionalParameterTypes.isEmpty) {
if (!first) {
- sb.add(', ');
+ sb.write(', ');
}
- sb.add('[');
+ sb.write('[');
optionalParameterTypes.printOn(sb, ', ');
- sb.add(']');
+ sb.write(']');
first = false;
}
if (!namedParameterTypes.isEmpty) {
if (!first) {
- sb.add(', ');
+ sb.write(', ');
}
- sb.add('{');
+ sb.write('{');
Link<SourceString> namedParameter = namedParameters;
Link<DartType> namedParameterType = namedParameterTypes;
first = true;
while (!namedParameter.isEmpty && !namedParameterType.isEmpty) {
if (!first) {
- sb.add(', ');
+ sb.write(', ');
}
- sb.add(namedParameterType.head);
- sb.add(' ');
- sb.add(namedParameter.head.slowToString());
+ sb.write(namedParameterType.head);
+ sb.write(' ');
+ sb.write(namedParameter.head.slowToString());
namedParameter = namedParameter.tail;
namedParameterType = namedParameterType.tail;
first = false;
}
- sb.add('}');
+ sb.write('}');
}
- sb.add(') -> ${returnType}');
+ sb.write(') -> ${returnType}');
return sb.toString();
}

Powered by Google App Engine
This is Rietveld 408576698