Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1070)

Unified Diff: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart

Issue 12294028: Fix warnings spotted by dart. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
diff --git a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
index f805355f634bccc366b0574aedde8def7f8eedd6..c195512b4bc623017f68f4b8890cb0f894c28f71 100644
--- a/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
+++ b/dart/sdk/lib/_internal/compiler/implementation/js_backend/emitter.dart
@@ -1350,7 +1350,7 @@ class CodeEmitterTask extends CompilerTask {
bool isFirstField = true;
StringBuffer buffer = new StringBuffer();
if (!classIsNative) {
- buffer.add('$superClass;');
+ buffer.write('$superClass;');
}
visitClassFields(classElement, (Element member,
String name,
@@ -1369,30 +1369,30 @@ class CodeEmitterTask extends CompilerTask {
if (isFirstField) {
isFirstField = false;
} else {
- buffer.add(',');
+ buffer.write(',');
}
int flag = 0;
if (!needsAccessor) {
// Emit field for constructor generation.
assert(!classIsNative);
- buffer.add(name);
+ buffer.write(name);
} else {
// Emit (possibly renaming) field name so we can add accessors at
// runtime.
- buffer.add(accessorName);
+ buffer.write(accessorName);
if (name != accessorName) {
- buffer.add(':$name');
+ buffer.write(':$name');
// Only the native classes can have renaming accessors.
assert(classIsNative);
flag = RENAMING_FLAG;
}
}
if (needsGetter && needsSetter) {
- buffer.addCharCode(GETTER_SETTER_CODE + flag);
+ buffer.writeCharCode(GETTER_SETTER_CODE + flag);
} else if (needsGetter) {
- buffer.addCharCode(GETTER_CODE + flag);
+ buffer.writeCharCode(GETTER_CODE + flag);
} else if (needsSetter) {
- buffer.addCharCode(SETTER_CODE + flag);
+ buffer.writeCharCode(SETTER_CODE + flag);
}
}
});

Powered by Google App Engine
This is Rietveld 408576698