Remove deprecated string features.

Remove deprecated string features.

Make String.codeUnits return a List.

Committed: https://code.google.com/p/dart/source/detail?r=18960

[Lasse Reichstein Nielsen, 2013-02-19 13:14:22]

Srdjan, please check the VM changes.

[floitsch, 2013-02-19 14:03:05]

LGTM.

https://codereview.chromium.org/12282038/diff/1/sdk/lib/core/string.dart
File sdk/lib/core/string.dart (right):

https://codereview.chromium.org/12282038/diff/1/sdk/lib/core/string.dart#newc...
sdk/lib/core/string.dart:462: class CodeUnits extends UnmodifiableListBase<int>
{
I would prefer if this class is not public. It's a list of ints.

https://codereview.chromium.org/12282038/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/12282038/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:675: LibTest/core/String/charCodes_A01_t01:
Fail
Don't forget to file co19 issue and update this file.

https://codereview.chromium.org/12282038/diff/1/tests/corelib/collection_to_s...
File tests/corelib/collection_to_string_test.dart (right):

https://codereview.chromium.org/12282038/diff/1/tests/corelib/collection_to_s...
tests/corelib/collection_to_string_test.dart:302: List<int> chars =
s.codeUnits.toList();
Add comment to explain why "toList" (make it modifiable).

https://codereview.chromium.org/12282038/diff/1/utils/tests/string_encoding/u...
File utils/tests/string_encoding/unicode_test.dart (right):

https://codereview.chromium.org/12282038/diff/1/utils/tests/string_encoding/u...
utils/tests/string_encoding/unicode_test.dart:33:
Expect.listEquals(testCodepoints, testPhrase.codeUnits());
that looks wrong: codeUnits is a getter.

https://codereview.chromium.org/12282038/diff/1/utils/tests/string_encoding/u...
utils/tests/string_encoding/unicode_test.dart:45: Expect.listEquals([],
"".codeUnits());
ditto.

[srdjan, 2013-02-19 17:28:44]

https://codereview.chromium.org/12282038/diff/1137/runtime/lib/string_base.dart
File runtime/lib/string_base.dart (right):

https://codereview.chromium.org/12282038/diff/1137/runtime/lib/string_base.da...
runtime/lib/string_base.dart:418: List<int> get codeUnits => new
CodeUnits(this);
How does this work? Does it run in checked mode?

new CodeUnits produces an instance of CodeUnits:
CodeUnits extends ListIterable<int>
ListIterable<E> extends Iterable<E>

However:
List<E> implements Collection<E>
Collection<E> extends Iterable<E>

https://codereview.chromium.org/12282038/diff/1137/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/12282038/diff/1137/runtime/vm/intermediate_la...
runtime/vm/intermediate_language.h:64: V(_StringBase, codeUnitAt,
StringBaseCodeUnitAt, 984449525)                  \
I would be really surprised if fingerprint remained unchanged although the
function name changed. DId you test the VM in debug mode?

[Lasse Reichstein Nielsen, 2013-02-20 06:38:23]

https://codereview.chromium.org/12282038/diff/1/sdk/lib/core/string.dart
File sdk/lib/core/string.dart (right):

https://codereview.chromium.org/12282038/diff/1/sdk/lib/core/string.dart#newc...
sdk/lib/core/string.dart:462: class CodeUnits extends UnmodifiableListBase<int>
{
Moved to _collection-dev.

https://codereview.chromium.org/12282038/diff/1/tests/co19/co19-dart2dart.status
File tests/co19/co19-dart2dart.status (right):

https://codereview.chromium.org/12282038/diff/1/tests/co19/co19-dart2dart.sta...
tests/co19/co19-dart2dart.status:675: LibTest/core/String/charCodes_A01_t01:
Fail
On 2013/02/19 14:03:06, floitsch wrote:
> Don't forget to file co19 issue and update this file.

Done.

https://codereview.chromium.org/12282038/diff/1/tests/corelib/collection_to_s...
File tests/corelib/collection_to_string_test.dart (right):

https://codereview.chromium.org/12282038/diff/1/tests/corelib/collection_to_s...
tests/corelib/collection_to_string_test.dart:302: List<int> chars =
s.codeUnits.toList();
On 2013/02/19 14:03:06, floitsch wrote:
> Add comment to explain why "toList" (make it modifiable).

Done.

https://codereview.chromium.org/12282038/diff/1/tests/corelib/collection_to_s...
tests/corelib/collection_to_string_test.dart:302: List<int> chars =
s.codeUnits.toList();
On 2013/02/19 14:03:06, floitsch wrote:
> Add comment to explain why "toList" (make it modifiable).

Done.

https://codereview.chromium.org/12282038/diff/1/utils/tests/string_encoding/u...
File utils/tests/string_encoding/unicode_test.dart (right):

https://codereview.chromium.org/12282038/diff/1/utils/tests/string_encoding/u...
utils/tests/string_encoding/unicode_test.dart:33:
Expect.listEquals(testCodepoints, testPhrase.codeUnits());
This code is definitly not running anywhere. The dunit.dart file contains what
is now syntax errors, and the path to lib/utf is wrong.
I'll fix enough to get this file running, and leave the rest to rot.

https://codereview.chromium.org/12282038/diff/1/utils/tests/string_encoding/u...
utils/tests/string_encoding/unicode_test.dart:45: Expect.listEquals([],
"".codeUnits());
On 2013/02/19 14:03:06, floitsch wrote:
> ditto.

Done.

https://codereview.chromium.org/12282038/diff/1137/runtime/lib/string_base.dart
File runtime/lib/string_base.dart (right):

https://codereview.chromium.org/12282038/diff/1137/runtime/lib/string_base.da...
runtime/lib/string_base.dart:418: List<int> get codeUnits => new
CodeUnits(this);
On 2013/02/19 17:28:44, srdjan wrote:
> How does this work? Does it run in checked mode?

Yes. CodeUnits was changed to be a List (extends UnmodifiableListBase, which
extends ListBase, which implements List).

> new CodeUnits produces an instance of CodeUnits:
> CodeUnits extends ListIterable<int>
> ListIterable<E> extends Iterable<E>
> 
> However:
> List<E> implements Collection<E>
> Collection<E> extends Iterable<E>

https://codereview.chromium.org/12282038/diff/1137/runtime/vm/intermediate_la...
File runtime/vm/intermediate_language.h (right):

https://codereview.chromium.org/12282038/diff/1137/runtime/vm/intermediate_la...
runtime/vm/intermediate_language.h:64: V(_StringBase, codeUnitAt,
StringBaseCodeUnitAt, 984449525)                  \
I did change it to 0, and got the same number back.

[srdjan, 2013-02-20 16:53:50]

LGTM for VM changes after testing that no performance regressions occur.

[Lasse Reichstein Nielsen, 2013-02-25 10:49:22]

Committed patchset #3 manually as r18960 (presubmit successful).