sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart - Issue 12282038: Remove deprecated string features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

Issue 12282038: Remove deprecated string features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « sdk/lib/_internal/compiler/implementation/lib/string_helper.dart ('k') | sdk/lib/_internal/compiler/implementation/scanner/byte_strings.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

diff --git a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

index 13a15f820dc1348786516cfbd4926f9f1e398e57..86b266683f4efb3dd1d5b2bd6ad8e8d6053a186b 100644

--- a/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

+++ b/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart

@@ -688,8 +688,8 @@ class Dart2JsSourceLocation implements SourceLocation {

var columnNumber = 0;

while (0 <= index && index < sourceText.length) {

columnNumber++;

- var charCode = sourceText.charCodeAt(index);

- if (charCode == $CR || charCode == $LF) {

+ var codeUnit = sourceText.codeUnitAt(index);

+ if (codeUnit == $CR || codeUnit == $LF) {

break;

}

index--;