samples/third_party/dromaeo/common/BenchUtil.dart - Issue 12282038: Remove deprecated string features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: samples/third_party/dromaeo/common/BenchUtil.dart

Issue 12282038: Remove deprecated string features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: samples/third_party/dromaeo/common/BenchUtil.dart

diff --git a/samples/third_party/dromaeo/common/BenchUtil.dart b/samples/third_party/dromaeo/common/BenchUtil.dart

index 3388980f751ddf3ff4d57dd724d7a167bfff4085..04520461e6056a2d3675e612052a920b9736a4ec 100644

--- a/samples/third_party/dromaeo/common/BenchUtil.dart

+++ b/samples/third_party/dromaeo/common/BenchUtil.dart

@@ -39,7 +39,7 @@ class BenchUtil {

}

static bool _inRange(int charCode, String start, String end) {

- return start.charCodeAt(0) <= charCode && charCode <= end.charCodeAt(0);

+ return start.codeUnitAt(0) <= charCode && charCode <= end.codeUnitAt(0);

}

static const String DIGITS = '0123456789ABCDEF';

@@ -50,7 +50,7 @@ class BenchUtil {

static String encodeUri(final String s) {

StringBuffer sb = new StringBuffer();

for (int i = 0; i < s.length; i++) {

- final int charCode = s.charCodeAt(i);

+ final int charCode = s.codeUnitAt(i);

final bool noEscape =

_inRange(charCode, '0', '9') ||

_inRange(charCode, 'a', 'z') ||