runtime/lib/mirrors_impl.dart - Issue 12282038: Remove deprecated string features.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/mirrors_impl.dart

Issue 12282038: Remove deprecated string features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Merge to head Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/lib/mirrors_impl.dart

diff --git a/runtime/lib/mirrors_impl.dart b/runtime/lib/mirrors_impl.dart

index 7ece1602aa0b2609efe8afb5974648e5d83cbd1d..d8c78e12bdbb34af710de83e3d7e8c006c528906 100644

--- a/runtime/lib/mirrors_impl.dart

+++ b/runtime/lib/mirrors_impl.dart

@@ -244,7 +244,8 @@ String _dartEscape(String str) {

output = r'\v';

break;

default:

- int code = input.charCodeAt(0);

+ // TODO(lrn): Someone decide if this should combine surrogate pairs.

+ int code = input.codeUnitAt(0);

if (isNice(code)) {

output = input;

} else {

« no previous file with comments | « runtime/lib/integers_patch.dart ('k') | runtime/lib/string.cc » ('j') | no next file with comments »