Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(243)

Unified Diff: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart

Issue 12282038: Remove deprecated string features. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Merge to head Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
diff --git a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
index c06de798eb4672538f0fe2a3fee8b01c7e621f2b..366a1bcbd0c8dfc55b76ef96bd54403fca5b2e81 100644
--- a/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
+++ b/sdk/lib/_internal/compiler/implementation/lib/js_helper.dart
@@ -210,19 +210,19 @@ class Primitives {
if (radix <= 10) {
// Allow all digits less than the radix. For example 0, 1, 2 for
// radix 3.
- // "0".charCodeAt(0) + radix - 1;
+ // "0".codeUnitAt(0) + radix - 1;
maxCharCode = 0x30 + radix - 1;
} else {
// Characters are located after the digits in ASCII. Therefore we
// only check for the character code. The regexp above made already
// sure that the string does not contain anything but digits or
// characters.
- // "0".charCodeAt(0) + radix - 1;
+ // "0".codeUnitAt(0) + radix - 1;
maxCharCode = 0x61 + radix - 10 - 1;
}
String digitsPart = match[digitsIndex].toLowerCase();
for (int i = 0; i < digitsPart.length; i++) {
- if (digitsPart.charCodeAt(i) > maxCharCode) {
+ if (digitsPart.codeUnitAt(i) > maxCharCode) {
return handleError(source);
}
}
@@ -255,7 +255,7 @@ class Primitives {
return result;
}
- /** [: r"$".charCodeAt(0) :] */
+ /** [: r"$".codeUnitAt(0) :] */
static const int DOLLAR_CHAR_VALUE = 36;
static String objectTypeName(Object object) {
@@ -270,7 +270,7 @@ class Primitives {
}
// TODO(kasperl): If the namer gave us a fresh global name, we may
// want to remove the numeric suffix that makes it unique too.
- if (identical(name.charCodeAt(0), DOLLAR_CHAR_VALUE)) name = name.substring(1);
+ if (identical(name.codeUnitAt(0), DOLLAR_CHAR_VALUE)) name = name.substring(1);
return name;
}

Powered by Google App Engine
This is Rietveld 408576698