sdk files reorganization to make dart2js a proper package

sdk files reorganization to make dart2js a proper package

BUG=
R=brianwilkerson@google.com, floitsch@google.com, whesse@google.com

Committed: https://github.com/dart-lang/sdk/commit/b18c5a3e7c64e1346c80466231679fd1b8db1951

[Siggi Cherem (dart-lang), 2015-06-25 17:00:34]

Patchset #1 (id:1) has been deleted

[Siggi Cherem (dart-lang), 2015-06-25 17:24:49]

sigmund@google.com changed reviewers:
+ brianwilkerson@google.com, floitsch@google.com, johnmccutchan@google.com,
ricow@google.com, sra@google.com, whesse@google.com

[Siggi Cherem (dart-lang), 2015-06-25 17:24:51]

This CL looks bigger than it is (most of it is file moves to a subdirectory),
but there are small changes here and there, so lots of reviewers :)

The main change for non-dart2js projects is that 
sdk/lib/_internal/libraries.dart is moved to:
sdk/lib/_internal/library_spec/lib/libraries.dart

(although I kept the old file and reexported the new one).


* Florian/Stephen - what do you think of the new organization of the compiler
runtime libraries? I could move more under compiler/, but given that most of the
library code needs to be shipped with the SDK, I think it's easier to keep it
under sdk/lib/_internal/.

* Brian - does the change to analyzer look OK?

* Rico/Bill - please take a look at the .gyp changes and the create_sdk.py
script.

* John/Zach/Devon/Phil - I'm ccing you because I believe you have (or may have)
a dependency on this, but not something I can fix in the SDK itself.
  John/Zach for the sky integration, Devon for compiler_unsupported/dart_pad,
Phil maybe for analyzer_cli?

Any other dependency I missed?

[Siggi Cherem (dart-lang), 2015-06-25 17:25:02]

Patchset #1 (id:20001) has been deleted

[pquitslund, 2015-06-25 17:40:57]

> * John/Zach/Devon/Phil - I'm ccing you because I believe you have (or may
have)
> a dependency on this, but not something I can fix in the SDK itself.
>   John/Zach for the sky integration, Devon for compiler_unsupported/dart_pad,
> Phil maybe for analyzer_cli?

I don't think this should affect analyzer_cli.  As long as
analyzer/src/generated/sdk_io.dart does the right thing, I think we're in the
clear.

[Brian Wilkerson, 2015-06-25 17:47:10]

The analyzer change LGTM. I didn't look at the rest.

[Bill Hesse, 2015-06-25 17:49:13]

The gyp file changes, and the create_sdk.py script look good to me. LGTM.

[Siggi Cherem (dart-lang), 2015-06-25 22:53:21]

+Peter for integratoin with fletch

[ahe, 2015-06-26 08:06:59]

ahe@google.com changed reviewers:
+ ahe@google.com

[ahe, 2015-06-26 08:07:01]

I like where this is going very much. Only real concern is that the new location
of JavaScript specific files doesn't include "js" or "JavaScript.

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler_runtime/lib/annotations.dart (right):

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler_runtime/lib/annotations.dart:1: // Copyright (c)
2013, the Dart project authors.  Please see the AUTHORS file
I'd like the path "sdk/lib/_internal/compiler_runtime/lib/" to include "js" or
"javascripts". In my opinion, the "compiler" is dart2js in the context of Dart,
but we have several backends, at least, JavaScript and Fletch bytecodes.

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/libra...
File sdk/lib/_internal/libraries_spec/pubspec.yaml (right):

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/libra...
sdk/lib/_internal/libraries_spec/pubspec.yaml:3: name: libraries_spec
Perhaps this package should have a less general sounding name. Something longer
and more annoying?

[Siggi Cherem (dart-lang), 2015-06-26 16:58:34]

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler_runtime/lib/annotations.dart (right):

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler_runtime/lib/annotations.dart:1: // Copyright (c)
2013, the Dart project authors.  Please see the AUTHORS file
On 2015/06/26 08:07:00, ahe wrote:
> I'd like the path "sdk/lib/_internal/compiler_runtime/lib/" to include "js" or
> "javascripts". In my opinion, the "compiler" is dart2js in the context of
Dart,
> but we have several backends, at least, JavaScript and Fletch bytecodes.

how about `js_runtime` or `dart2js_runtime`?

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/libra...
File sdk/lib/_internal/libraries_spec/pubspec.yaml (right):

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/libra...
sdk/lib/_internal/libraries_spec/pubspec.yaml:3: name: libraries_spec
On 2015/06/26 08:07:01, ahe wrote:
> Perhaps this package should have a less general sounding name. Something
longer
> and more annoying?

I wasn't intending to publish it though, so we don't really need to make it too
long or annoying :)

Some ideas:
 - sdk_lib_spec
 - sdk_lib_layout
 - sdk_lib_metadata
 - sdk_library_metadata
 - sdk_metadata

Thoughts?

[ahe, 2015-06-26 17:24:25]

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/compi...
File sdk/lib/_internal/compiler_runtime/lib/annotations.dart (right):

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/compi...
sdk/lib/_internal/compiler_runtime/lib/annotations.dart:1: // Copyright (c)
2013, the Dart project authors.  Please see the AUTHORS file
On 2015/06/26 16:58:34, Siggi Cherem (dart-lang) wrote:
> On 2015/06/26 08:07:00, ahe wrote:
> > I'd like the path "sdk/lib/_internal/compiler_runtime/lib/" to include "js"
or
> > "javascripts". In my opinion, the "compiler" is dart2js in the context of
> Dart,
> > but we have several backends, at least, JavaScript and Fletch bytecodes.
> 
> how about `js_runtime` or `dart2js_runtime`?

They are both good.

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/libra...
File sdk/lib/_internal/libraries_spec/pubspec.yaml (right):

https://codereview.chromium.org/1212513002/diff/40001/sdk/lib/_internal/libra...
sdk/lib/_internal/libraries_spec/pubspec.yaml:3: name: libraries_spec
On 2015/06/26 16:58:34, Siggi Cherem (dart-lang) wrote:
> On 2015/06/26 08:07:01, ahe wrote:
> > Perhaps this package should have a less general sounding name. Something
> longer
> > and more annoying?
> 
> I wasn't intending to publish it though, so we don't really need to make it
too
> long or annoying :)
> 
> Some ideas:
>  - sdk_lib_spec
>  - sdk_lib_layout
>  - sdk_lib_metadata
>  - sdk_library_metadata
>  - sdk_metadata
> 
> Thoughts?

I don't really have a strong opinion, but sdk_library_metadata sounds pretty
good to me.

[Siggi Cherem (dart-lang), 2015-06-26 21:16:47]

updated to the new names.

Florian or Stephen - I'll wait for your lgtm before submitting.

[Siggi Cherem (dart-lang), 2015-06-26 23:19:44]

Patchset #2 (id:60001) has been deleted

[floitsch, 2015-06-29 09:08:23]

LGTM.

https://chromiumcodereview.appspot.com/1212513002/diff/80001/pkg/compiler/lib...
File pkg/compiler/lib/src/library_loader.dart (right):

https://chromiumcodereview.appspot.com/1212513002/diff/80001/pkg/compiler/lib...
pkg/compiler/lib/src/library_loader.dart:105: *
'sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart'. This is done
through
long line.

[Siggi Cherem (dart-lang), 2015-06-29 16:19:13]

https://chromiumcodereview.appspot.com/1212513002/diff/80001/pkg/compiler/lib...
File pkg/compiler/lib/src/library_loader.dart (right):

https://chromiumcodereview.appspot.com/1212513002/diff/80001/pkg/compiler/lib...
pkg/compiler/lib/src/library_loader.dart:105: *
'sdk/lib/_internal/sdk_library_metadata/lib/libraries.dart'. This is done
through
On 2015/06/29 09:08:23, floitsch wrote:
> long line.

thx, oops, it got even longer after the second time I renamed things

[Siggi Cherem (dart-lang), 2015-06-29 17:21:23]

Committed patchset #2 (id:80001) manually as
b18c5a3e7c64e1346c80466231679fd1b8db1951 (presubmit successful).