Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(663)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182053010: Revert "Split TypedSelector into Selector and TypeMask." (Closed)

Created:
5 years, 6 months ago by karlklose
Modified:
5 years, 6 months ago
Reviewers:
Johnni Winther
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Split TypedSelector into Selector and TypeMask." This reverts commit fc42c0e3bd30b3249f930d521a42af53366abcfd. R=johnniwinther@google.com Committed: https://github.com/dart-lang/sdk/commit/9fb192bbb045b1f0d9c5181a21d6b61a10cd0d6e

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+741 lines, -1198 lines) Patch
M pkg/compiler/lib/src/compiler.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 10 chunks +10 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 34 chunks +67 lines, -88 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 3 chunks +0 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 4 chunks +6 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 2 chunks +7 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 6 chunks +10 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 9 chunks +39 lines, -37 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/concrete_types_inferrer.dart View 9 chunks +16 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 3 chunks +3 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 43 chunks +87 lines, -162 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 12 chunks +32 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 14 chunks +39 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 3 chunks +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 3 chunks +4 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 3 chunks +16 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/old_emitter/nsm_emitter.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 4 chunks +10 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 19 chunks +27 lines, -49 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 5 chunks +21 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 3 chunks +7 lines, -75 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 37 chunks +54 lines, -104 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 5 chunks +15 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 4 chunks +12 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 19 chunks +33 lines, -69 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 9 chunks +17 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 3 chunks +7 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 3 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 chunk +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 chunk +1 line, -4 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 2 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 5 chunks +24 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 6 chunks +96 lines, -130 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 3 chunks +6 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 4 chunks +13 lines, -20 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +0 lines, -1 line 0 comments Download
M tests/compiler/dart2js/cpa_inference_test.dart View 3 chunks +7 lines, -15 lines 0 comments Download
M tests/compiler/dart2js/gvn_dynamic_field_get_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/compiler/dart2js/patch_test.dart View 3 chunks +14 lines, -11 lines 0 comments Download
M tests/language/language_dart2js.status View 2 chunks +3 lines, -24 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
karlklose
5 years, 6 months ago (2015-06-18 13:10:44 UTC) #1
karlklose
Committed patchset #1 (id:1) manually as 9fb192bbb045b1f0d9c5181a21d6b61a10cd0d6e (presubmit successful).
5 years, 6 months ago (2015-06-18 13:10:58 UTC) #2
Johnni Winther
5 years, 6 months ago (2015-06-18 13:12:22 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698