Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(284)

Side by Side Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1182053010: Revert "Split TypedSelector into Selector and TypeMask." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library code_generator; 5 library code_generator;
6 6
7 import 'glue.dart'; 7 import 'glue.dart';
8 8
9 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir; 9 import '../../tree_ir/tree_ir_nodes.dart' as tree_ir;
10 import '../../tree_ir/tree_ir_nodes.dart' show BuiltinOperator; 10 import '../../tree_ir/tree_ir_nodes.dart' show BuiltinOperator;
11 import '../../js/js.dart' as js; 11 import '../../js/js.dart' as js;
12 import '../../elements/elements.dart'; 12 import '../../elements/elements.dart';
13 import '../../io/source_information.dart' show SourceInformation; 13 import '../../io/source_information.dart' show SourceInformation;
14 import '../../util/maplet.dart'; 14 import '../../util/maplet.dart';
15 import '../../constants/values.dart'; 15 import '../../constants/values.dart';
16 import '../../dart2jslib.dart'; 16 import '../../dart2jslib.dart';
17 import '../../dart_types.dart'; 17 import '../../dart_types.dart';
18 import '../../types/types.dart' show TypeMask;
19 import '../../universe/universe.dart' show UniverseSelector;
20 import '../../closure.dart' show ClosureClassElement; 18 import '../../closure.dart' show ClosureClassElement;
21 19
22 class CodegenBailout { 20 class CodegenBailout {
23 final tree_ir.Node node; 21 final tree_ir.Node node;
24 final String reason; 22 final String reason;
25 CodegenBailout(this.node, this.reason); 23 CodegenBailout(this.node, this.reason);
26 String get message { 24 String get message {
27 return 'bailout${node != null ? " on $node" : ""}: $reason'; 25 return 'bailout${node != null ? " on $node" : ""}: $reason';
28 } 26 }
29 } 27 }
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
248 246
249 registry.registerInstantiatedType(node.type); 247 registry.registerInstantiatedType(node.type);
250 Selector selector = node.selector; 248 Selector selector = node.selector;
251 FunctionElement target = node.target; 249 FunctionElement target = node.target;
252 List<js.Expression> arguments = visitExpressionList(node.arguments); 250 List<js.Expression> arguments = visitExpressionList(node.arguments);
253 return buildStaticInvoke(selector, target, arguments); 251 return buildStaticInvoke(selector, target, arguments);
254 } 252 }
255 253
256 void registerMethodInvoke(tree_ir.InvokeMethod node) { 254 void registerMethodInvoke(tree_ir.InvokeMethod node) {
257 Selector selector = node.selector; 255 Selector selector = node.selector;
258 TypeMask mask = node.mask;
259 if (selector.isGetter) { 256 if (selector.isGetter) {
260 registry.registerDynamicGetter(new UniverseSelector(selector, mask)); 257 registry.registerDynamicGetter(selector);
261 } else if (selector.isSetter) { 258 } else if (selector.isSetter) {
262 registry.registerDynamicSetter(new UniverseSelector(selector, mask)); 259 registry.registerDynamicSetter(selector);
263 } else { 260 } else {
264 assert(invariant(CURRENT_ELEMENT_SPANNABLE, 261 assert(invariant(CURRENT_ELEMENT_SPANNABLE,
265 selector.isCall || selector.isOperator || 262 selector.isCall || selector.isOperator ||
266 selector.isIndex || selector.isIndexSet, 263 selector.isIndex || selector.isIndexSet,
267 message: 'unexpected kind ${selector.kind}')); 264 message: 'unexpected kind ${selector.kind}'));
268 // TODO(sigurdm): We should find a better place to register the call. 265 // TODO(sigurdm): We should find a better place to register the call.
269 Selector call = new Selector.callClosureFrom(selector); 266 Selector call = new Selector.callClosureFrom(selector);
270 registry.registerDynamicInvocation(new UniverseSelector(call, null)); 267 registry.registerDynamicInvocation(call);
271 registry.registerDynamicInvocation(new UniverseSelector(selector, mask)); 268 registry.registerDynamicInvocation(selector);
272 } 269 }
273 } 270 }
274 271
275 @override 272 @override
276 js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) { 273 js.Expression visitInvokeMethod(tree_ir.InvokeMethod node) {
277 registerMethodInvoke(node); 274 registerMethodInvoke(node);
278 return js.propertyCall(visitExpression(node.receiver), 275 return js.propertyCall(visitExpression(node.receiver),
279 glue.invocationName(node.selector), 276 glue.invocationName(node.selector),
280 visitExpressionList(node.arguments)); 277 visitExpressionList(node.arguments));
281 } 278 }
(...skipping 465 matching lines...) Expand 10 before | Expand all | Expand 10 after
747 return js.js("typeof # === 'number' && Math.floor(#) === #", args); 744 return js.js("typeof # === 'number' && Math.floor(#) === #", args);
748 } 745 }
749 } 746 }
750 747
751 visitFunctionExpression(tree_ir.FunctionExpression node) { 748 visitFunctionExpression(tree_ir.FunctionExpression node) {
752 // FunctionExpressions are currently unused. 749 // FunctionExpressions are currently unused.
753 // We might need them if we want to emit raw JS nested functions. 750 // We might need them if we want to emit raw JS nested functions.
754 throw 'FunctionExpressions should not be used'; 751 throw 'FunctionExpressions should not be used';
755 } 752 }
756 } 753 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_emitter/class_stub_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698