Revert "Split TypedSelector into Selector and TypeMask."

pkg/compiler/lib/src/universe/function_set.dart

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of universe;
 
 // TODO(kasperl): This actually holds getters and setters just fine
 // too and stricly they aren't functions. Maybe this needs a better
 // name -- something like ElementSet seems a bit too generic.
 class FunctionSet {
@@ skipping 30 matching lines @@
     FunctionSetNode node = nodes[name];
     return (node != null)
         ? node.contains(element)
         : false;
   }
 
   /**
    * Returns an object that allows iterating over all the functions
    * that may be invoked with the given [selector].
    */
-  Iterable<Element> filter(Selector selector, TypeMask mask) {
-    return query(selector, mask).functions;
+  Iterable<Element> filter(Selector selector) {
+    return query(selector).functions;
   }
 
-  TypeMask receiverType(Selector selector, TypeMask mask) {
-    return query(selector, mask).computeMask(compiler.world);
+  TypeMask receiverType(Selector selector) {
+    return query(selector).computeMask(compiler.world);
   }
 
-  FunctionSetQuery query(Selector selector, TypeMask mask) {
+  FunctionSetQuery query(Selector selector) {
     String name = selector.name;
     FunctionSetNode node = nodes[name];
     FunctionSetNode noSuchMethods = nodes[Compiler.NO_SUCH_METHOD];
     if (node != null) {
-      return node.query(selector, mask, compiler, noSuchMethods);
+      return node.query(selector, compiler, noSuchMethods);
     }
     // If there is no method that matches [selector] we know we can
     // only hit [:noSuchMethod:].
     if (noSuchMethods == null) return const FunctionSetQuery(const <Element>[]);
-    return noSuchMethods.query(
-        compiler.noSuchMethodSelector, mask, compiler, null);
+    selector = (selector.mask == null)
+        ? compiler.noSuchMethodSelector
+        : new TypedSelector(selector.mask, compiler.noSuchMethodSelector,
+            compiler.world);
+
+    return noSuchMethods.query(selector, compiler, null);
   }
 
   void forEach(Function action) {
     nodes.forEach((String name, FunctionSetNode node) {
       node.forEach(action);
     });
   }
 }
 
 
 class FunctionSetNode {
   final String name;
-  final Map<Selector, Map<TypeMask, FunctionSetQuery>> cache =
-      <Selector, Map<TypeMask, FunctionSetQuery>>{};
+  final Map<Selector, FunctionSetQuery> cache =
+      new Map<Selector, FunctionSetQuery>();
 
   // Initially, we keep the elements in a list because it is more
   // compact than a hash set. Once we get enough elements, we change
   // the representation to be a set to get faster contains checks.
   static const int MAX_ELEMENTS_IN_LIST = 8;
   var elements = <Element>[];
   bool isList = true;
 
   FunctionSetNode(this.name);
 
@@ skipping 36 matching lines @@
 
   bool contains(Element element) {
     assert(element.name == name);
     return elements.contains(element);
   }
 
   void forEach(Function action) {
     elements.forEach(action);
   }
 
-  TypeMask getNonNullTypeMaskOfSelector(TypeMask mask, Compiler compiler) {
+  TypeMask getNonNullTypeMaskOfSelector(Selector selector, Compiler compiler) {
     // TODO(ngeoffray): We should probably change untyped selector
     // to always be a subclass of Object.
-    return mask != null
-        ? mask
+    return selector.mask != null
+        ? selector.mask
         : new TypeMask.subclass(compiler.objectClass, compiler.world);
     }
 
   FunctionSetQuery query(Selector selector,
-                         TypeMask mask,
                          Compiler compiler,
                          FunctionSetNode noSuchMethods) {
     ClassWorld classWorld = compiler.world;
     assert(selector.name == name);
-    Map<TypeMask, FunctionSetQuery> cacheMap =
-        cache.putIfAbsent(
-            selector, () => new Maplet<TypeMask, FunctionSetQuery>());
-    FunctionSetQuery result = cacheMap[mask];
+    FunctionSetQuery result = cache[selector];
     if (result != null) return result;
-
     Setlet<Element> functions;
     for (Element element in elements) {
-      if (selector.appliesUnnamed(element, classWorld) &&
-          (mask == null || mask.canHit(element, selector, classWorld))) {
+      if (selector.appliesUnnamed(element, classWorld)) {
         if (functions == null) {
           // Defer the allocation of the functions set until we are
           // sure we need it. This allows us to return immutable empty
           // lists when the filtering produced no results.
           functions = new Setlet<Element>();
         }
         functions.add(element);
       }
     }
 
-    mask = getNonNullTypeMaskOfSelector(mask, compiler);
+    TypeMask mask = getNonNullTypeMaskOfSelector(selector, compiler);
     // If we cannot ensure a method will be found at runtime, we also
     // add [noSuchMethod] implementations that apply to [mask] as
     // potential targets.
     if (noSuchMethods != null
         && mask.needsNoSuchMethodHandling(selector, classWorld)) {
       FunctionSetQuery noSuchMethodQuery = noSuchMethods.query(
-          compiler.noSuchMethodSelector,
-          mask,
+          new TypedSelector(
+              mask, compiler.noSuchMethodSelector, classWorld),
           compiler,
           null);
       if (!noSuchMethodQuery.functions.isEmpty) {
         if (functions == null) {
           functions = new Setlet<Element>.from(noSuchMethodQuery.functions);
         } else {
           functions.addAll(noSuchMethodQuery.functions);
         }
       }
     }
-    cacheMap[mask] = result = (functions != null)
-        ? newQuery(functions, selector, mask, compiler)
+    cache[selector] = result = (functions != null)
+        ? newQuery(functions, selector, compiler)
         : const FunctionSetQuery(const <Element>[]);
     return result;
   }
 
   FunctionSetQuery newQuery(Iterable<Element> functions,
                             Selector selector,
-                            TypeMask mask,
                             Compiler compiler) {
     return new FullFunctionSetQuery(functions);
   }
 }
 
 class FunctionSetQuery {
   final Iterable<Element> functions;
   TypeMask computeMask(ClassWorld classWorld) => const TypeMask.nonNullEmpty();
   const FunctionSetQuery(this.functions);
 }
@@ skipping 17 matching lines @@
             return const TypeMask.empty();
           } else {
             return new TypeMask.nonNullSubclass(cls.declaration, classWorld);
           }
         }),
         classWorld);
   }
 
   FullFunctionSetQuery(functions) : super(functions);
 }