Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(746)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1182053010: Revert "Split TypedSelector into Selector and TypeMask." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index ac10ae7414dbb6e7f3c3f5f07376a473dd282629..7ae47a5c134e79a5ad369d2a07259bf3dd9c03d7 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -58,8 +58,8 @@ class TypeMaskSystem {
return inferrer.getGuaranteedReturnTypeOfElement(function);
}
- TypeMask getInvokeReturnType(Selector selector, TypeMask mask) {
- return inferrer.getGuaranteedTypeOfSelector(selector, mask);
+ TypeMask getInvokeReturnType(Selector typedSelector) {
+ return inferrer.getGuaranteedTypeOfSelector(typedSelector);
}
TypeMask getFieldType(FieldElement field) {
@@ -337,8 +337,8 @@ class ConstantPropagationLattice {
/// The possible return types of a method that may be targeted by
/// [typedSelector]. If the given selector is not a [TypedSelector], any
/// reachable method matching the selector may be targeted.
- AbstractValue getInvokeReturnType(Selector selector, TypeMask mask) {
- return nonConstant(typeSystem.getInvokeReturnType(selector, mask));
+ AbstractValue getInvokeReturnType(Selector typedSelector) {
+ return nonConstant(typeSystem.getInvokeReturnType(typedSelector));
}
}
@@ -947,7 +947,7 @@ class TypePropagationVisitor implements Visitor {
}
if (!node.selector.isOperator) {
// TODO(jgruber): Handle known methods on constants such as String.length.
- setResult(lattice.getInvokeReturnType(node.selector, node.mask));
+ setResult(lattice.getInvokeReturnType(node.selector));
return;
}
@@ -974,7 +974,7 @@ class TypePropagationVisitor implements Visitor {
// Update value of the continuation parameter. Again, this is effectively
// a phi.
if (result == null) {
- setResult(lattice.getInvokeReturnType(node.selector, node.mask));
+ setResult(lattice.getInvokeReturnType(node.selector));
} else {
setResult(result, canReplace: true);
}
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart ('k') | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698