Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(848)

Unified Diff: pkg/compiler/lib/src/js_backend/codegen/codegen.dart

Issue 1182053010: Revert "Split TypedSelector into Selector and TypeMask." (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/codegen/codegen.dart
diff --git a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
index 0e7f886e1fc01d176db999cf028411bee2f2da84..78ccd5829e5cb30eaef2996fc59e5e308f9eba5c 100644
--- a/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
+++ b/pkg/compiler/lib/src/js_backend/codegen/codegen.dart
@@ -15,8 +15,6 @@ import '../../util/maplet.dart';
import '../../constants/values.dart';
import '../../dart2jslib.dart';
import '../../dart_types.dart';
-import '../../types/types.dart' show TypeMask;
-import '../../universe/universe.dart' show UniverseSelector;
import '../../closure.dart' show ClosureClassElement;
class CodegenBailout {
@@ -255,11 +253,10 @@ class CodeGenerator extends tree_ir.StatementVisitor
void registerMethodInvoke(tree_ir.InvokeMethod node) {
Selector selector = node.selector;
- TypeMask mask = node.mask;
if (selector.isGetter) {
- registry.registerDynamicGetter(new UniverseSelector(selector, mask));
+ registry.registerDynamicGetter(selector);
} else if (selector.isSetter) {
- registry.registerDynamicSetter(new UniverseSelector(selector, mask));
+ registry.registerDynamicSetter(selector);
} else {
assert(invariant(CURRENT_ELEMENT_SPANNABLE,
selector.isCall || selector.isOperator ||
@@ -267,8 +264,8 @@ class CodeGenerator extends tree_ir.StatementVisitor
message: 'unexpected kind ${selector.kind}'));
// TODO(sigurdm): We should find a better place to register the call.
Selector call = new Selector.callClosureFrom(selector);
- registry.registerDynamicInvocation(new UniverseSelector(call, null));
- registry.registerDynamicInvocation(new UniverseSelector(selector, mask));
+ registry.registerDynamicInvocation(call);
+ registry.registerDynamicInvocation(selector);
}
}
« no previous file with comments | « pkg/compiler/lib/src/js_backend/backend.dart ('k') | pkg/compiler/lib/src/js_emitter/class_stub_generator.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698