Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(10)

Issue 1165363004: Remove computeSignature from FunctionElement. (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -35 lines) Patch
M pkg/compiler/lib/src/compile_time_constants.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 chunk +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 chunk +0 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 2 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 2 chunks +5 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 3 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-09 13:48:24 UTC) #2
karlklose
LGTM.
5 years, 6 months ago (2015-06-10 07:06:16 UTC) #3
Johnni Winther
5 years, 6 months ago (2015-06-11 13:07:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6414489318a1e0829a9331d9ee28f45044f75b48 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698