Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(206)

Unified Diff: pkg/compiler/lib/src/resolution/members.dart

Issue 1165363004: Remove computeSignature from FunctionElement. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/resolution/class_hierarchy.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/resolution/members.dart
diff --git a/pkg/compiler/lib/src/resolution/members.dart b/pkg/compiler/lib/src/resolution/members.dart
index 27dda38d8150b044756529368e0c2db331daabea..58e91605a813b5034f4a24fc5d50b5456309907f 100644
--- a/pkg/compiler/lib/src/resolution/members.dart
+++ b/pkg/compiler/lib/src/resolution/members.dart
@@ -1997,7 +1997,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
} else {
if (target is FunctionElement) {
FunctionElement function = target;
- function.computeSignature(compiler);
+ function.computeType(compiler);
}
if (!selector.applies(target, compiler.world)) {
registry.registerThrowNoSuchMethod();
@@ -2360,10 +2360,10 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
{'fromType': targetType, 'toType': constructorType});
}
- FunctionSignature targetSignature =
- redirectionTarget.computeSignature(compiler);
- FunctionSignature constructorSignature =
- constructor.computeSignature(compiler);
+ redirectionTarget.computeType(compiler);
+ FunctionSignature targetSignature = redirectionTarget.functionSignature;
+ constructor.computeType(compiler);
+ FunctionSignature constructorSignature = constructor.functionSignature;
if (!targetSignature.isCompatibleWith(constructorSignature)) {
assert(!isSubtype);
registry.registerThrowNoSuchMethod();
@@ -2478,7 +2478,7 @@ class ResolverVisitor extends MappingVisitor<ResolutionResult> {
if (Elements.isUnresolved(constructor)) {
return new ResolutionResult.forElement(constructor);
}
- constructor.computeSignature(compiler);
+ constructor.computeType(compiler);
if (!callSelector.applies(constructor, compiler.world)) {
registry.registerThrowNoSuchMethod();
}
« no previous file with comments | « pkg/compiler/lib/src/resolution/class_hierarchy.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698