pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart - Issue 1165363004: Remove computeSignature from FunctionElement.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

Issue 1165363004: Remove computeSignature from FunctionElement. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

diff --git a/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart b/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

index 6afef1bb9577051bd3dc4c836bac31fa345c5c68..a13db64f16ffeb8002c0c9af344c535d073f94c4 100644

--- a/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

+++ b/pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

@@ -192,7 +192,7 @@ class CustomElementsAnalysisJoin {

if (member.isGenerativeConstructor) {

// Ignore constructors that cannot be called with zero arguments.

FunctionElement constructor = member;

- constructor.computeSignature(compiler);

+ constructor.computeType(compiler);

FunctionSignature parameters = constructor.functionSignature;

if (parameters.requiredParameterCount == 0) {

result.add(member);