Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(653)

Side by Side Diff: pkg/compiler/lib/src/elements/elements.dart

Issue 1165363004: Remove computeSignature from FunctionElement. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2012, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library elements; 5 library elements;
6 6
7 7
8 import '../constants/expressions.dart'; 8 import '../constants/expressions.dart';
9 import '../tree/tree.dart'; 9 import '../tree/tree.dart';
10 import '../util/util.dart'; 10 import '../util/util.dart';
(...skipping 1111 matching lines...) Expand 10 before | Expand all | Expand 10 after
1122 abstract class FunctionElement extends Element 1122 abstract class FunctionElement extends Element
1123 implements AstElement, 1123 implements AstElement,
1124 TypedElement, 1124 TypedElement,
1125 FunctionTypedElement, 1125 FunctionTypedElement,
1126 ExecutableElement { 1126 ExecutableElement {
1127 FunctionExpression get node; 1127 FunctionExpression get node;
1128 1128
1129 FunctionElement get patch; 1129 FunctionElement get patch;
1130 FunctionElement get origin; 1130 FunctionElement get origin;
1131 1131
1132 /// Do not use [computeSignature] outside of the resolver; instead retrieve
1133 /// the signature through the [functionSignature] field.
1134 /// Trying to access a function signature that has not been computed in
1135 /// resolution is an error and calling [computeSignature] covers that error.
1136 /// This method will go away!
1137 // TODO(johnniwinther): Rename to `ensureFunctionSignature`.
1138 @deprecated FunctionSignature computeSignature(Compiler compiler);
1139
1140 bool get hasFunctionSignature; 1132 bool get hasFunctionSignature;
1141 1133
1142 /// The parameters of this functions. 1134 /// The parameters of this functions.
1143 List<ParameterElement> get parameters; 1135 List<ParameterElement> get parameters;
1144 1136
1145 /// The type of this function. 1137 /// The type of this function.
1146 FunctionType get type; 1138 FunctionType get type;
1147 1139
1148 /// The synchronous/asynchronous marker on this function. 1140 /// The synchronous/asynchronous marker on this function.
1149 AsyncMarker get asyncMarker; 1141 AsyncMarker get asyncMarker;
(...skipping 494 matching lines...) Expand 10 before | Expand all | Expand 10 after
1644 bool get isDeclaredByField; 1636 bool get isDeclaredByField;
1645 1637
1646 /// Returns `true` if this member is abstract. 1638 /// Returns `true` if this member is abstract.
1647 bool get isAbstract; 1639 bool get isAbstract;
1648 1640
1649 /// If abstract, [implementation] points to the overridden concrete member, 1641 /// If abstract, [implementation] points to the overridden concrete member,
1650 /// if any. Otherwise [implementation] points to the member itself. 1642 /// if any. Otherwise [implementation] points to the member itself.
1651 Member get implementation; 1643 Member get implementation;
1652 } 1644 }
1653 1645
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/dart_backend/backend.dart ('k') | pkg/compiler/lib/src/elements/modelx.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698