Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Side by Side Diff: pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart

Issue 1165363004: Remove computeSignature from FunctionElement. (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/resolution/class_hierarchy.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 part of js_backend; 5 part of js_backend;
6 6
7 /** 7 /**
8 * Support for Custom Elements. 8 * Support for Custom Elements.
9 * 9 *
10 * The support for custom elements the compiler builds a table that maps the 10 * The support for custom elements the compiler builds a table that maps the
(...skipping 174 matching lines...) Expand 10 before | Expand all | Expand 10 after
185 List<Element> result = <Element>[]; 185 List<Element> result = <Element>[];
186 // Only classes that extend native classes have constructors in the table. 186 // Only classes that extend native classes have constructors in the table.
187 // We could refine this to classes that extend Element, but that would break 187 // We could refine this to classes that extend Element, but that would break
188 // the tests and there is no sane reason to subclass other native classes. 188 // the tests and there is no sane reason to subclass other native classes.
189 if (classElement.isNative) return result; 189 if (classElement.isNative) return result;
190 190
191 selectGenerativeConstructors(ClassElement enclosing, Element member) { 191 selectGenerativeConstructors(ClassElement enclosing, Element member) {
192 if (member.isGenerativeConstructor) { 192 if (member.isGenerativeConstructor) {
193 // Ignore constructors that cannot be called with zero arguments. 193 // Ignore constructors that cannot be called with zero arguments.
194 FunctionElement constructor = member; 194 FunctionElement constructor = member;
195 constructor.computeSignature(compiler); 195 constructor.computeType(compiler);
196 FunctionSignature parameters = constructor.functionSignature; 196 FunctionSignature parameters = constructor.functionSignature;
197 if (parameters.requiredParameterCount == 0) { 197 if (parameters.requiredParameterCount == 0) {
198 result.add(member); 198 result.add(member);
199 } 199 }
200 } 200 }
201 } 201 }
202 classElement.forEachMember(selectGenerativeConstructors, 202 classElement.forEachMember(selectGenerativeConstructors,
203 includeBackendMembers: false, 203 includeBackendMembers: false,
204 includeSuperAndInjectedMembers: false); 204 includeSuperAndInjectedMembers: false);
205 return result; 205 return result;
206 } 206 }
207 } 207 }
OLDNEW
« no previous file with comments | « pkg/compiler/lib/src/enqueue.dart ('k') | pkg/compiler/lib/src/resolution/class_hierarchy.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698