Issue 11639007: Cleanup the exceptions create code to use Arrays instead GrowableArrays so

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11639007: Cleanup the exceptions create code to use Arrays instead GrowableArrays so (Closed)

Created:
8 years ago by siva

Modified:
8 years ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/

Visibility:
Public.

More Reviews

Description

Cleanup the exceptions create code to use Arrays instead GrowableArrays so that it is consistent with the DartEntry invoke code that it calls finally. Committed: https://code.google.com/p/dart/source/detail?r=16295

Patch Set 1 #

Created: 8 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+112 lines, -117 lines)			Patch
M	lib/array.cc	View	5 chunks	+15 lines, -15 lines	0 comments	Download
M	lib/byte_array.cc	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/date.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/double.cc	View	5 chunks	+13 lines, -14 lines	0 comments	Download
M	lib/growable_array.cc	View	4 chunks	+8 lines, -8 lines	0 comments	Download
M	lib/integers.cc	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	lib/isolate.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	lib/object.cc	View	2 chunks	+6 lines, -6 lines	0 comments	Download
M	lib/regexp.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/regexp_jsc.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	lib/string.cc	View	3 chunks	+11 lines, -11 lines	0 comments	Download
M	vm/bigint_operations.cc	View	1 chunk	+3 lines, -3 lines	0 comments	Download
M	vm/dart_entry.h	View	1 chunk	+3 lines, -4 lines	0 comments	Download
M	vm/dart_entry.cc	View	2 chunks	+13 lines, -12 lines	0 comments	Download
M	vm/exceptions.h	View	1 chunk	+2 lines, -4 lines	0 comments	Download
M	vm/exceptions.cc	View	3 chunks	+3 lines, -5 lines	0 comments	Download
M	vm/isolate.cc	View	1 chunk	+4 lines, -4 lines	0 comments	Download
M	vm/native_entry.h	View	2 chunks	+4 lines, -4 lines	0 comments	Download
M	vm/object_store.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	vm/snapshot.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

LGTM!

Expand Messages | Collapse Messages