Cleanup the exceptions create code to use Arrays instead GrowableArrays so

lib/string.cc

 // Copyright (c) 2011, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/bootstrap_natives.h"
 
 #include "vm/exceptions.h"
 #include "vm/native_entry.h"
 #include "vm/object.h"
 #include "vm/symbols.h"
 #include "vm/unicode.h"
 
 namespace dart {
 
 DEFINE_NATIVE_ENTRY(StringBase_createFromCodePoints, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Array, a, arguments->NativeArgAt(0));
   // TODO(srdjan): Check that parameterized type is an int.
   Zone* zone = isolate->current_zone();
   intptr_t array_len = a.Length();
 
   // Unbox the array and determine the maximum element width.
   bool is_one_byte_string = true;
   intptr_t utf16_len = array_len;
   int32_t* utf32_array = zone->Alloc<int32_t>(array_len);
   Object& index_object = Object::Handle(isolate);
   for (intptr_t i = 0; i < array_len; i++) {
     index_object = a.At(i);
     if (!index_object.IsSmi()) {
-      GrowableArray<const Object*> args;
-      args.Add(&index_object);
+      const Array& args = Array::Handle(Array::New(1));
+      args.SetAt(0, index_object);
       Exceptions::ThrowByType(Exceptions::kArgument, args);
     }
     intptr_t value = Smi::Cast(index_object).Value();
     if (Utf::IsOutOfRange(value)) {
-      GrowableArray<const Object*> args;
+      const Array& args = Array::Handle(Object::empty_array());
       Exceptions::ThrowByType(Exceptions::kArgument, args);
     } else {
       if (!Utf::IsLatin1(value)) {
         is_one_byte_string = false;
         if (Utf::IsSupplementary(value)) {
           utf16_len += 1;
         }
       }
     }
     utf32_array[i] = value;
@@ skipping 75 matching lines @@
   return Smi::New(receiver.Length());
 }
 
 
 static int32_t StringValueAt(const String& str, const Integer& index) {
   if (index.IsSmi()) {
     Smi& smi = Smi::Handle();
     smi ^= index.raw();
     int32_t index = smi.Value();
     if ((index < 0) || (index >= str.Length())) {
-      GrowableArray<const Object*> arguments;
-      arguments.Add(&smi);
-      Exceptions::ThrowByType(Exceptions::kRange, arguments);
+      const Array& args = Array::Handle(Array::New(1));
+      args.SetAt(0, smi);
+      Exceptions::ThrowByType(Exceptions::kRange, args);
     }
     return str.CharAt(index);
   } else {
     // An index larger than Smi is always illegal.
-    GrowableArray<const Object*> arguments;
-    arguments.Add(&index);
-    Exceptions::ThrowByType(Exceptions::kRange, arguments);
+    const Array& args = Array::Handle(Array::New(1));
+    args.SetAt(0, index);
+    Exceptions::ThrowByType(Exceptions::kRange, args);
     return 0;
   }
 }
 
 
 DEFINE_NATIVE_ENTRY(String_charAt, 2) {
   const String& receiver = String::CheckedHandle(arguments->NativeArgAt(0));
   GET_NON_NULL_NATIVE_ARGUMENT(Integer, index, arguments->NativeArgAt(1));
   uint32_t value = StringValueAt(receiver, index);
   ASSERT(value <= 0x10FFFF);
@@ skipping 33 matching lines @@
 
 
 DEFINE_NATIVE_ENTRY(Strings_concatAll, 1) {
   GET_NON_NULL_NATIVE_ARGUMENT(Array, strings, arguments->NativeArgAt(0));
   ASSERT(!strings.IsNull());
   // Check that the array contains strings.
   Instance& elem = Instance::Handle();
   for (intptr_t i = 0; i < strings.Length(); i++) {
     elem ^= strings.At(i);
     if (!elem.IsString()) {
-      GrowableArray<const Object*> args;
-      args.Add(&elem);
+      const Array& args = Array::Handle(Array::New(1));
+      args.SetAt(0, elem);
       Exceptions::ThrowByType(Exceptions::kArgument, args);
     }
   }
   return String::ConcatAll(strings);
 }
 
 }  // namespace dart