Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(247)

Unified Diff: lib/regexp_jsc.cc

Issue 11639007: Cleanup the exceptions create code to use Arrays instead GrowableArrays so (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/regexp.cc ('k') | lib/string.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/regexp_jsc.cc
===================================================================
--- lib/regexp_jsc.cc (revision 16285)
+++ lib/regexp_jsc.cc (working copy)
@@ -44,9 +44,9 @@
error_msg = "Unknown regexp compile error";
}
const String& errmsg = String::Handle(String::New(error_msg));
- GrowableArray<const Object*> args;
- args.Add(&pattern);
- args.Add(&errmsg);
+ const Array& args = Array::Handle(Array::New(2));
+ args.SetAt(0, pattern);
+ args.SetAt(1, errmsg);
Exceptions::ThrowByType(Exceptions::kIllegalJSRegExp, args);
}
« no previous file with comments | « lib/regexp.cc ('k') | lib/string.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698