Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Unified Diff: vm/native_entry.h

Issue 11639007: Cleanup the exceptions create code to use Arrays instead GrowableArrays so (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « vm/isolate.cc ('k') | vm/object_store.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: vm/native_entry.h
===================================================================
--- vm/native_entry.h (revision 16285)
+++ vm/native_entry.h (working copy)
@@ -57,8 +57,8 @@
const Instance& __##name##_instance__ = \
Instance::CheckedHandle(isolate, value); \
if (!__##name##_instance__.Is##type()) { \
- GrowableArray<const Object*> __args__; \
- __args__.Add(&__##name##_instance__); \
+ const Array& __args__ = Array::Handle(Array::New(1)); \
+ __args__.SetAt(0, __##name##_instance__); \
Exceptions::ThrowByType(Exceptions::kArgument, __args__); \
} \
const type& name = type::Cast(__##name##_instance__);
@@ -72,8 +72,8 @@
type& name = type::Handle(isolate); \
if (!__##name##_instance__.IsNull()) { \
if (!__##name##_instance__.Is##type()) { \
- GrowableArray<const Object*> __args__; \
- __args__.Add(&__##name##_instance__); \
+ const Array& __args__ = Array::Handle(Array::New(1)); \
+ __args__.SetAt(0, __##name##_instance__); \
Exceptions::ThrowByType(Exceptions::kArgument, __args__); \
} \
} \
« no previous file with comments | « vm/isolate.cc ('k') | vm/object_store.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698