Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Unified Diff: lib/date.cc

Issue 11639007: Cleanup the exceptions create code to use Arrays instead GrowableArrays so (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/runtime/
Patch Set: Created 8 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « lib/byte_array.cc ('k') | lib/double.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/date.cc
===================================================================
--- lib/date.cc (revision 16285)
+++ lib/date.cc (working copy)
@@ -20,8 +20,8 @@
Integer, dart_seconds, arguments->NativeArgAt(0));
int64_t seconds = dart_seconds.AsInt64Value();
if (seconds < 0 || seconds > kMaxAllowedSeconds) {
- GrowableArray<const Object*> args;
- args.Add(&dart_seconds);
+ const Array& args = Array::Handle(Array::New(1));
+ args.SetAt(0, dart_seconds);
Exceptions::ThrowByType(Exceptions::kArgument, args);
}
const char* name = OS::GetTimeZoneName(seconds);
@@ -34,8 +34,8 @@
Integer, dart_seconds, arguments->NativeArgAt(0));
int64_t seconds = dart_seconds.AsInt64Value();
if (seconds < 0 || seconds > kMaxAllowedSeconds) {
- GrowableArray<const Object*> args;
- args.Add(&dart_seconds);
+ const Array& args = Array::Handle(Array::New(1));
+ args.SetAt(0, dart_seconds);
Exceptions::ThrowByType(Exceptions::kArgument, args);
}
int offset = OS::GetTimeZoneOffsetInSeconds(seconds);
« no previous file with comments | « lib/byte_array.cc ('k') | lib/double.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698