Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(96)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1161823004: Handle .fromEnvironment and incompatible constructor invocations (Closed)

Created:
5 years, 6 months ago by Johnni Winther
Modified:
5 years, 6 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org, Anders Johnsen
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Handle .fromEnvironment and incompatible constructor invocations BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/411246ccc7032bb6cf31a578a765d244653bf3a3

Patch Set 1 #

Total comments: 6

Patch Set 2 : Updated cf. comments #

Patch Set 3 : Rebased #

Patch Set 4 : Change handling of incompatible redirecting factories. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+433 lines, -192 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 1 chunk +11 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 2 chunks +15 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 3 chunks +47 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 3 chunks +95 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 3 4 chunks +47 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 chunk +29 lines, -3 lines 0 comments Download
M tests/co19/co19-dart2js.status View 1 2 3 2 chunks +0 lines, -7 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 chunk +5 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_decl_visitor.dart View 1 chunk +0 lines, -145 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 1 2 3 5 chunks +119 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 1 chunk +64 lines, -0 lines 0 comments Download
M tests/corelib/corelib.status View 1 2 3 3 chunks +0 lines, -4 lines 0 comments Download
M tests/isolate/isolate.status View 1 2 3 2 chunks +0 lines, -2 lines 0 comments Download
M tests/language/language_dart2js.status View 1 2 3 5 chunks +1 line, -11 lines 0 comments Download

Messages

Total messages: 8 (1 generated)
Johnni Winther
5 years, 6 months ago (2015-06-01 11:25:04 UTC) #2
Johnni Winther
5 years, 6 months ago (2015-06-01 11:37:24 UTC) #3
karlklose
LGTM. https://codereview.chromium.org/1161823004/diff/1/pkg/compiler/lib/src/resolution/access_semantics.dart File pkg/compiler/lib/src/resolution/access_semantics.dart (right): https://codereview.chromium.org/1161823004/diff/1/pkg/compiler/lib/src/resolution/access_semantics.dart#newcode517 pkg/compiler/lib/src/resolution/access_semantics.dart:517: String toString() => 'ConstructorAccessSemantics($kind,$element,$type)'; Add spaces after ','? ...
5 years, 6 months ago (2015-06-01 11:47:26 UTC) #4
Johnni Winther
https://codereview.chromium.org/1161823004/diff/1/pkg/compiler/lib/src/resolution/access_semantics.dart File pkg/compiler/lib/src/resolution/access_semantics.dart (right): https://codereview.chromium.org/1161823004/diff/1/pkg/compiler/lib/src/resolution/access_semantics.dart#newcode517 pkg/compiler/lib/src/resolution/access_semantics.dart:517: String toString() => 'ConstructorAccessSemantics($kind,$element,$type)'; On 2015/06/01 11:47:26, karlklose wrote: ...
5 years, 6 months ago (2015-06-01 13:13:43 UTC) #5
Johnni Winther
PTAL @ the last patch
5 years, 6 months ago (2015-06-01 15:05:42 UTC) #6
karlklose
Last patch set LGTM.
5 years, 6 months ago (2015-06-02 07:46:50 UTC) #7
Johnni Winther
5 years, 6 months ago (2015-06-02 08:44:29 UTC) #8
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) manually as
411246ccc7032bb6cf31a578a765d244653bf3a3 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698