tests/compiler/dart2js/semantic_visitor_test.dart - Issue 1161823004: Handle .fromEnvironment and incompatible constructor invocations

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/compiler/dart2js/semantic_visitor_test.dart

Issue 1161823004: Handle .fromEnvironment and incompatible constructor invocations (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Change handling of incompatible redirecting factories. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tests/compiler/dart2js/semantic_visitor_test.dart

diff --git a/tests/compiler/dart2js/semantic_visitor_test.dart b/tests/compiler/dart2js/semantic_visitor_test.dart

index c9a487ec2a12d606ac605a88280ae6e1b488811a..c1712c566da110d4ab8207585edbf9bb052a0c7b 100644

--- a/tests/compiler/dart2js/semantic_visitor_test.dart

+++ b/tests/compiler/dart2js/semantic_visitor_test.dart

@@ -622,10 +622,15 @@ enum VisitKind {

VISIT_AS,

VISIT_CONST_CONSTRUCTOR_INVOKE,

+ VISIT_BOOL_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,

+ VISIT_INT_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,

+ VISIT_STRING_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,

VISIT_GENERATIVE_CONSTRUCTOR_INVOKE,

VISIT_REDIRECTING_GENERATIVE_CONSTRUCTOR_INVOKE,

VISIT_FACTORY_CONSTRUCTOR_INVOKE,

VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,

+ VISIT_CONSTRUCTOR_INCOMPATIBLE_INVOKE,

+ ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,

VISIT_SUPER_CONSTRUCTOR_INVOKE,

VISIT_IMPLICIT_SUPER_CONSTRUCTOR_INVOKE,