Handle .fromEnvironment and incompatible constructor invocations

pkg/compiler/lib/src/resolution/access_semantics.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 // TODO(johnniwinther): Temporarily copied from analyzer2dart. Merge when
 // we shared code with the analyzer and this semantic visitor is complete.
 
 /**
  * Code for classifying the semantics of identifiers appearing in a Dart file.
  */
@@ skipping 456 matching lines @@
 
   /// An invocation of an ill-defined redirecting factory constructor.
   ///
   /// For instance
   ///     class C {
   ///       factory C() = Unresolved;
   ///     }
   ///     m() => new C();
   ///
   ERRONEOUS_REDIRECTING_FACTORY,
+
+
+  /// An invocation of a constructor with incompatible arguments.
+  ///
+  /// For instance
+  ///     class C {
+  ///       C();
+  ///     }
+  ///     m() => new C(true);
+  ///
+  INCOMPATIBLE,
 }
 
 /// Data structure used to classify the semantics of a constructor invocation.
 class ConstructorAccessSemantics {
   /// The kind of constructor invocation.
   final ConstructorAccessKind kind;
 
   /// The invoked constructor.
   final Element element;
 
   /// The type on which the constructor is invoked.
   final DartType type;
 
   ConstructorAccessSemantics(this.kind, this.element, this.type);
 
   /// The effect target of the access. Used to defined redirecting factory
   /// constructor invocations.
   ConstructorAccessSemantics get effectiveTargetSemantics => this;
 
   /// `true` if this invocation is erroneous.
   bool get isErroneous {
     return kind == ConstructorAccessKind.ABSTRACT ||
            kind == ConstructorAccessKind.UNRESOLVED_TYPE ||
            kind == ConstructorAccessKind.UNRESOLVED_CONSTRUCTOR ||
            kind == ConstructorAccessKind.NON_CONSTANT_CONSTRUCTOR ||
-           kind == ConstructorAccessKind.ERRONEOUS_REDIRECTING_FACTORY;
+           kind == ConstructorAccessKind.ERRONEOUS_REDIRECTING_FACTORY ||
+           kind == ConstructorAccessKind.INCOMPATIBLE;
   }
+
+  String toString() => 'ConstructorAccessSemantics($kind, $element, $type)';
 }
 
 /// Data structure used to classify the semantics of a redirecting factory
 /// constructor invocation.
 class RedirectingFactoryConstructorAccessSemantics
     extends ConstructorAccessSemantics {
   final ConstructorAccessSemantics effectiveTargetSemantics;
 
   RedirectingFactoryConstructorAccessSemantics(
       ConstructorAccessKind kind,
       Element element,
       DartType type,
       this.effectiveTargetSemantics)
       : super(kind, element, type);
 }