Handle .fromEnvironment and incompatible constructor invocations

tests/compiler/dart2js/semantic_visitor_test_send_data.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 part of dart2js.semantics_visitor_test;
 
 const Map<String, List<Test>> SEND_TESTS = const {
   'Parameters': const [
     // Parameters
     const Test('m(o) => o;',
@@ skipping 3071 matching lines @@
         '''
         class Class {
           const Class(a, b);
         }
         m() => const Class(true, 42);
         ''',
         const Visit(VisitKind.VISIT_CONST_CONSTRUCTOR_INVOKE,
             constant: 'const Class(true, 42)')),
     const Test(
         '''
+        m() => const bool.fromEnvironment('foo');
+        ''',
+        const Visit(VisitKind.VISIT_BOOL_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,
+            constant: 'const bool.fromEnvironment("foo", defaultValue: false)')),

[karlklose, 2015/06/01 11:47:26]

Long line.

[Johnni Winther, 2015/06/01 13:13:43]

Done.

+    const Test(
+        '''
+        m() => const bool.fromEnvironment('foo', defaultValue: true);
+        ''',
+        const Visit(VisitKind.VISIT_BOOL_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,
+            constant: 'const bool.fromEnvironment("foo", defaultValue: true)')),
+    const Test(
+        '''
+        m() => const int.fromEnvironment('foo');
+        ''',
+        const Visit(VisitKind.VISIT_INT_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,
+            constant: 'const int.fromEnvironment("foo", defaultValue: null)')),
+    const Test(
+        '''
+        m() => const String.fromEnvironment('foo');
+        ''',
+        const Visit(VisitKind.VISIT_STRING_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,
+            constant:
+                'const String.fromEnvironment("foo", defaultValue: null)')),
+    const Test(
+        '''
+        class Class {
+          Class(a, b);
+        }
+        m() => const Class(true, 42);
+        ''',
+        const Visit(VisitKind.ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,
+            element: 'generative_constructor(Class#)',
+            arguments: '(true,42)',

[karlklose, 2015/06/01 11:47:26]

Space after ','? (also below)

[Johnni Winther, 2015/06/01 13:13:43]

No. It's checked against unparser output.

+            type: 'Class',
+            selector: 'CallStructure(arity=2)')),
+    const Test(
+        '''
         class Class {}
         m() => new Class();
         ''',
         const Visit(VisitKind.VISIT_GENERATIVE_CONSTRUCTOR_INVOKE,
             element: 'generative_constructor(Class#)',
             arguments: '()',
             type: 'Class',
             selector: 'CallStructure(arity=0)')),
     const Test(
         '''
@@ skipping 14 matching lines @@
         }
         m() => new Class.named(true, 42);
         ''',
         const Visit(VisitKind.VISIT_GENERATIVE_CONSTRUCTOR_INVOKE,
             element: 'generative_constructor(Class#named)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
+        class Class {}
+        m() => new Class(true, 42);
+        ''',
+        const Visit(VisitKind.VISIT_CONSTRUCTOR_INCOMPATIBLE_INVOKE,
+            element: 'generative_constructor(Class#)',
+            arguments: '(true,42)',
+            type: 'Class',
+            selector: 'CallStructure(arity=2)')),
+    const Test(
+        '''
         class Class {
           Class(a, b) : this._(a, b);
           Class._(a, b);
         }
         m() => new Class(true, 42);
         ''',
         const Visit(VisitKind.VISIT_REDIRECTING_GENERATIVE_CONSTRUCTOR_INVOKE,
             element: 'generative_constructor(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
+          Class() : this._(true, 42);
+          Class._(a, b);
+        }
+        m() => new Class(true, 42);
+        ''',
+        const Visit(VisitKind.VISIT_CONSTRUCTOR_INCOMPATIBLE_INVOKE,
+            element: 'generative_constructor(Class#)',
+            arguments: '(true,42)',
+            type: 'Class',
+            selector: 'CallStructure(arity=2)')),
+    const Test(
+        '''
+        class Class {
           factory Class(a, b) => new Class._(a, b);
           Class._(a, b);
         }
         m() => new Class(true, 42);
         ''',
         const Visit(VisitKind.VISIT_FACTORY_CONSTRUCTOR_INVOKE,
             element: 'function(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
+        class Class {
+          factory Class() => new Class._(true, 42);
+          Class._(a, b);
+        }
+        m() => new Class(true, 42);
+        ''',
+        const Visit(VisitKind.VISIT_CONSTRUCTOR_INCOMPATIBLE_INVOKE,
+            element: 'function(Class#)',
+            arguments: '(true,42)',
+            type: 'Class',
+            selector: 'CallStructure(arity=2)')),
+    const Test(
+        '''
         class Class<T> {
           factory Class(a, b) = Class<int>.a;
           factory Class.a(a, b) = Class<Class<T>>.b;
           Class.b(a, b);
         }
         m() => new Class<double>(true, 42);
         ''',
         const Visit(VisitKind.VISIT_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
             element: 'function(Class#)',
             arguments: '(true,42)',
             type: 'Class<double>',
             target: 'generative_constructor(Class#b)',
             targetType: 'Class<Class<int>>',
             selector: 'CallStructure(arity=2)')),
     const Test(
         '''
         class Class {
+          factory Class() = Class._;
+          Class._();
+        }
+        m() => new Class(true, 42);
+        ''',
+        const Visit(VisitKind.VISIT_CONSTRUCTOR_INCOMPATIBLE_INVOKE,
+            element: 'function(Class#)',
+            arguments: '(true,42)',
+            type: 'Class',
+            selector: 'CallStructure(arity=2)')),
+    const Test(
+        '''
+        class Class {
           Class(a, b);
         }
         m() => new Class.unresolved(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_CONSTRUCTOR_INVOKE,
             arguments: '(true,42)')),
     const Test(
         '''
         m() => new Unresolved(true, 42);
@@ skipping 63 matching lines @@
         m() => new Class(true, 42);
         ''',
         const Visit(
             VisitKind.VISIT_UNRESOLVED_REDIRECTING_FACTORY_CONSTRUCTOR_INVOKE,
             element: 'function(Class#)',
             arguments: '(true,42)',
             type: 'Class',
             selector: 'CallStructure(arity=2)')),
   ],
 };