Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(245)

Unified Diff: tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart

Issue 1161823004: Handle .fromEnvironment and incompatible constructor invocations (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Change handling of incompatible redirecting factories. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/compiler/dart2js/semantic_visitor_test_send_data.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart
diff --git a/tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart b/tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart
index f5a39534075afb15899b648ec1ef0bcac365f1f6..1021ee0a8ac7c3b2983bf727e9c9d19b6895f203 100644
--- a/tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart
+++ b/tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart
@@ -2338,6 +2338,70 @@ class SemanticSendTestVisitor extends SemanticTestVisitor {
arg) {
visits.add(new Visit(VisitKind.VISIT_CONST_CONSTRUCTOR_INVOKE,
constant: constant.getText()));
+ super.visitConstConstructorInvoke(node, constant, arg);
+ }
+
+ @override
+ visitBoolFromEnvironmentConstructorInvoke(
+ NewExpression node,
+ BoolFromEnvironmentConstantExpression constant,
+ arg) {
+ visits.add(new Visit(
+ VisitKind.VISIT_BOOL_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,
+ constant: constant.getText()));
+ super.visitBoolFromEnvironmentConstructorInvoke(node, constant, arg);
+ }
+
+ @override
+ visitIntFromEnvironmentConstructorInvoke(
+ NewExpression node,
+ IntFromEnvironmentConstantExpression constant,
+ arg) {
+ visits.add(new Visit(
+ VisitKind.VISIT_INT_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,
+ constant: constant.getText()));
+ super.visitIntFromEnvironmentConstructorInvoke(node, constant, arg);
+ }
+
+ @override
+ visitStringFromEnvironmentConstructorInvoke(
+ NewExpression node,
+ StringFromEnvironmentConstantExpression constant,
+ arg) {
+ visits.add(new Visit(
+ VisitKind.VISIT_STRING_FROM_ENVIRONMENT_CONSTRUCTOR_INVOKE,
+ constant: constant.getText()));
+ super.visitStringFromEnvironmentConstructorInvoke(node, constant, arg);
+ }
+
+ @override
+ errorNonConstantConstructorInvoke(
+ NewExpression node,
+ Element element,
+ DartType type,
+ NodeList arguments,
+ CallStructure callStructure,
+ arg) {
+ visits.add(new Visit(VisitKind.ERROR_NON_CONSTANT_CONSTRUCTOR_INVOKE,
+ element: element, type: type,
+ arguments: arguments, selector: callStructure));
+ super.errorNonConstantConstructorInvoke(
+ node, element, type, arguments, callStructure, arg);
+ }
+
+ @override
+ visitConstructorIncompatibleInvoke(
+ NewExpression node,
+ ConstructorElement constructor,
+ InterfaceType type,
+ NodeList arguments,
+ CallStructure callStructure,
+ arg) {
+ visits.add(new Visit(VisitKind.VISIT_CONSTRUCTOR_INCOMPATIBLE_INVOKE,
+ element: constructor, type: type,
+ arguments: arguments, selector: callStructure));
+ super.visitConstructorIncompatibleInvoke(
+ node, constructor, type, arguments, callStructure, arg);
}
@override
« no previous file with comments | « tests/compiler/dart2js/semantic_visitor_test_send_data.dart ('k') | tests/corelib/corelib.status » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698