Issue 1148343004: Remove ConstantExpression.value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1148343004: Remove ConstantExpression.value (Closed)

Created:
5 years, 6 months ago by Johnni Winther

Modified:
5 years, 6 months ago

Reviewers:
karlklose

CC:
reviews_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Remove ConstantExpression.value BUG= R=karlklose@google.com Committed: https://github.com/dart-lang/sdk/commit/4f969bbc3b1a233c4a6268b2210625d4120cba2a

Patch Set 1 #

Patch Set 2 : Update comments. #

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+590 lines, -416 lines)			Patch
M	pkg/compiler/lib/src/compile_time_constants.dart	View	1	32 chunks	+209 lines, -115 lines	0 comments	Download
M	pkg/compiler/lib/src/compiler.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/constants/constructors.dart	View		9 chunks	+14 lines, -15 lines	0 comments	Download
M	pkg/compiler/lib/src/constants/expressions.dart	View		43 chunks	+45 lines, -83 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart	View		7 chunks	+36 lines, -29 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart	View		10 chunks	+18 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart	View		1 chunk	+1 line, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/cps_ir/type_propagation.dart	View		5 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/dart_backend/backend.dart	View		2 chunks	+43 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/dart_backend/dart_backend.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/deferred_load.dart	View		4 chunks	+17 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart	View		2 chunks	+6 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart	View		1 chunk	+3 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/backend.dart	View		9 chunks	+20 lines, -11 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/codegen.dart	View		2 chunks	+5 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/glue.dart	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/codegen/unsugar.dart	View		1 chunk	+6 lines, -8 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart	View		5 chunks	+37 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/js_backend/type_variable_handler.dart	View		1 chunk	+14 lines, -17 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/metadata_collector.dart	View		2 chunks	+9 lines, -9 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/old_emitter/emitter.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart	View		1 chunk	+2 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/js_emitter/program_builder.dart	View		2 chunks	+7 lines, -7 lines	0 comments	Download
M	pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/mirrors_used.dart	View		3 chunks	+7 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/native/behavior.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/native/enqueue.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/patch_parser.dart	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/members.dart	View		4 chunks	+5 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/resolution/resolution_common.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View		4 chunks	+10 lines, -10 lines	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart	View		1 chunk	+4 lines, -4 lines	0 comments	Download
M	pkg/compiler/lib/src/typechecker.dart	View		2 chunks	+6 lines, -5 lines	0 comments	Download
M	pkg/compiler/lib/src/use_unused_api.dart	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	tests/compiler/dart2js/const_exp_test.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/memory_compiler.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	tests/compiler/dart2js/message_kind_helper.dart	View		2 chunks	+12 lines, -1 line	0 comments	Download
M	tests/compiler/dart2js/metadata_test.dart	View		5 chunks	+14 lines, -7 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Johnni Winther

5 years, 6 months ago (2015-06-02 13:23:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4f969bbc3b1a233c4a6268b2210625d4120cba2a (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages