pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart - Issue 1148343004: Remove ConstantExpression.value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

Issue 1148343004: Remove ConstantExpression.value (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Update comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

diff --git a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

index bd070c738c1bc19c50e829e74561d2ad0acb049b..bccbce84ef88848779263eb1bbbe65b3250e7238 100644

--- a/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

+++ b/pkg/compiler/lib/src/js_emitter/old_emitter/container_builder.dart

@@ -141,7 +141,7 @@ class ContainerBuilder extends CodeEmitterHelper {

Iterable<int> metadataIndices =

parameter.metadata.map((MetadataAnnotation annotation) {

ConstantValue constant =

- backend.constants.getConstantForMetadata(annotation).value;

+ backend.constants.getConstantValueForMetadata(annotation);

backend.constants.addCompileTimeConstantForEmission(constant);

return task.metadataCollector.reifyMetadata(annotation);

});