pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart - Issue 1148343004: Remove ConstantExpression.value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

Issue 1148343004: Remove ConstantExpression.value (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Update comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

diff --git a/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart b/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

index 86c95ccf26d7278e7ca0574aab25ee5e021db4a0..51ab110822a6f9bfe708270b64ed7876c4da2064 100644

--- a/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

+++ b/pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart

@@ -220,7 +220,9 @@ abstract class Dart2JsElementMirror extends Dart2JsDeclarationMirror {

mirrorSystem.compiler.commentMap[metadata.beginToken]);

metadata.ensureResolved(mirrorSystem.compiler);

_metadata.add(_convertConstantToInstanceMirror(

- mirrorSystem, metadata.constant, metadata.constant.value));

+ mirrorSystem, metadata.constant,

+ mirrorSystem.compiler.constants.getConstantValue(

+ metadata.constant)));

}

_appendCommentTokens(mirrorSystem.compiler.commentMap[getBeginToken()]);

}