pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart - Issue 1148343004: Remove ConstantExpression.value

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

Issue 1148343004: Remove ConstantExpression.value (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Update comments. Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

diff --git a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

index d052121e9ce2ce1aec11e740784e965075c61085..90e500b083965d64c8d98dcba87977a0fb1ac2d2 100644

--- a/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

+++ b/pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart

@@ -670,10 +670,9 @@ class CreateInvocationMirror extends Primitive {

class Constant extends Primitive {

final ConstantExpression expression;

+ final values.ConstantValue value;

- Constant(this.expression);

- values.ConstantValue get value => expression.value;

+ Constant(this.expression, this.value);

accept(Visitor visitor) => visitor.visitConstant(this);

}