Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(110)

Unified Diff: pkg/compiler/lib/src/cps_ir/type_propagation.dart

Issue 1148343004: Remove ConstantExpression.value (Closed) Base URL: https://github.com/dart-lang/sdk.git@master
Patch Set: Update comments. Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart ('k') | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/cps_ir/type_propagation.dart
diff --git a/pkg/compiler/lib/src/cps_ir/type_propagation.dart b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
index 3d3f98d31af4a0a94ac0158dd65580556db5ac24..a3a1c4528c3f73b63711d421cd293ad2c43b37f4 100644
--- a/pkg/compiler/lib/src/cps_ir/type_propagation.dart
+++ b/pkg/compiler/lib/src/cps_ir/type_propagation.dart
@@ -209,7 +209,7 @@ class _TransformingVisitor<T> extends RecursiveVisitor {
PrimitiveConstantValue primitiveConstant = value.constant;
ConstantExpression constExp =
const ConstantExpressionCreator().convert(primitiveConstant);
- Constant constant = new Constant(constExp);
+ Constant constant = new Constant(constExp, primitiveConstant);
LetPrim letPrim = new LetPrim(constant);
InvokeContinuation invoke =
new InvokeContinuation(continuation, <Primitive>[constant]);
@@ -988,7 +988,7 @@ class ConstantExpressionCreator
@override
ConstantExpression visitBool(BoolConstantValue constant, _) {
- return new BoolConstantExpression(constant.primitiveValue, constant);
+ return new BoolConstantExpression(constant.primitiveValue);
}
@override
@@ -1003,7 +1003,7 @@ class ConstantExpressionCreator
@override
ConstantExpression visitDouble(DoubleConstantValue constant, arg) {
- return new DoubleConstantExpression(constant.primitiveValue, constant);
+ return new DoubleConstantExpression(constant.primitiveValue);
}
@override
@@ -1018,7 +1018,7 @@ class ConstantExpressionCreator
@override
ConstantExpression visitInt(IntConstantValue constant, arg) {
- return new IntConstantExpression(constant.primitiveValue, constant);
+ return new IntConstantExpression(constant.primitiveValue);
}
@override
@@ -1038,13 +1038,13 @@ class ConstantExpressionCreator
@override
ConstantExpression visitNull(NullConstantValue constant, arg) {
- return new NullConstantExpression(constant);
+ return new NullConstantExpression();
}
@override
ConstantExpression visitString(StringConstantValue constant, arg) {
return new StringConstantExpression(
- constant.primitiveValue.slowToString(), constant);
+ constant.primitiveValue.slowToString());
}
@override
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart ('k') | pkg/compiler/lib/src/dart_backend/backend.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698