Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(960)

Issue 11419086: Use a signed 32-bit integer for representing code points. (Closed)

Created:
8 years, 1 month ago by cshapiro
Modified:
8 years, 1 month ago
Reviewers:
siva
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Use a signed 32-bit integer for representing code points. Committed: https://code.google.com/p/dart/source/detail?r=15188

Patch Set 1 #

Patch Set 2 : add missing files #

Unified diffs Side-by-side diffs Delta from patch set Stats (+225 lines, -225 lines) Patch
M runtime/include/dart_api.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/string.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/object.h View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/object.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/object_test.cc View 11 chunks +22 lines, -22 lines 0 comments Download
M runtime/vm/scanner.h View 1 chunk +3 lines, -3 lines 0 comments Download
M runtime/vm/scanner.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M runtime/vm/symbols.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/symbols.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M runtime/vm/unicode.h View 1 1 chunk +2 lines, -2 lines 0 comments Download
M runtime/vm/unicode.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/unicode_test.cc View 1 85 chunks +172 lines, -172 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
cshapiro
8 years, 1 month ago (2012-11-20 03:37:10 UTC) #1
siva
8 years, 1 month ago (2012-11-21 00:14:06 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698