Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(548)

Unified Diff: runtime/vm/scanner.cc

Issue 11419086: Use a signed 32-bit integer for representing code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: add missing files Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/scanner.h ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/scanner.cc
diff --git a/runtime/vm/scanner.cc b/runtime/vm/scanner.cc
index acdf30048a758cccdff1182512ed5f678b7c74a1..12e414d4db749d75030ed08a98b0688ee655c6a8 100644
--- a/runtime/vm/scanner.cc
+++ b/runtime/vm/scanner.cc
@@ -468,7 +468,7 @@ void Scanner::ScanLiteralString(bool is_raw) {
}
-bool Scanner::ScanHexDigits(int digits, uint32_t* value) {
+bool Scanner::ScanHexDigits(int digits, int32_t* value) {
*value = 0;
for (int i = 0; i < digits; ++i) {
ReadChar();
@@ -483,7 +483,7 @@ bool Scanner::ScanHexDigits(int digits, uint32_t* value) {
}
-bool Scanner::ScanHexDigits(int min_digits, int max_digits, uint32_t* value) {
+bool Scanner::ScanHexDigits(int min_digits, int max_digits, int32_t* value) {
*value = 0;
ReadChar();
for (int i = 0; i < max_digits; ++i) {
@@ -502,7 +502,7 @@ bool Scanner::ScanHexDigits(int min_digits, int max_digits, uint32_t* value) {
}
-void Scanner::ScanEscapedCodePoint(uint32_t* code_point) {
+void Scanner::ScanEscapedCodePoint(int32_t* code_point) {
ASSERT(c0_ == 'u' || c0_ == 'x');
bool is_valid;
if (c0_ == 'x') {
@@ -528,7 +528,7 @@ void Scanner::ScanEscapedCodePoint(uint32_t* code_point) {
void Scanner::ScanLiteralStringChars(bool is_raw) {
- GrowableArray<uint32_t> string_chars(64);
+ GrowableArray<int32_t> string_chars(64);
ASSERT(IsScanningString());
// We are at the first character of a string literal piece. A string literal
@@ -541,7 +541,7 @@ void Scanner::ScanLiteralStringChars(bool is_raw) {
}
if (c0_ == '\\' && !is_raw) {
// Parse escape sequence.
- uint32_t escape_char = '\0';
+ int32_t escape_char = '\0';
ReadChar();
switch (c0_) {
case 'n':
« no previous file with comments | « runtime/vm/scanner.h ('k') | runtime/vm/symbols.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698