runtime/lib/string.cc - Issue 11419086: Use a signed 32-bit integer for representing code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/lib/string.cc

Issue 11419086: Use a signed 32-bit integer for representing code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: add missing files Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/lib/string.cc

diff --git a/runtime/lib/string.cc b/runtime/lib/string.cc

index 7a446b61ccdd248e4cc291da635560003df9d125..f0fce3e325a8705ae20d8322d08fc6d7eeb2c501 100644

--- a/runtime/lib/string.cc

+++ b/runtime/lib/string.cc

@@ -20,7 +20,7 @@ DEFINE_NATIVE_ENTRY(StringBase_createFromCodePoints, 1) {

// Unbox the array and determine the maximum element width.

bool is_one_byte_string = true;

intptr_t utf16_len = array_len;

- uint32_t* utf32_array = zone->Alloc<uint32_t>(array_len);

+ int32_t* utf32_array = zone->Alloc<int32_t>(array_len);

Object& index_object = Object::Handle(isolate);

for (intptr_t i = 0; i < array_len; i++) {

index_object = a.At(i);

« no previous file with comments | « runtime/include/dart_api.h ('k') | runtime/vm/dart_api_impl.cc » ('j') | no next file with comments »