Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(343)

Unified Diff: runtime/vm/symbols.cc

Issue 11419086: Use a signed 32-bit integer for representing code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: add missing files Created 8 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/symbols.h ('k') | runtime/vm/unicode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/symbols.cc
diff --git a/runtime/vm/symbols.cc b/runtime/vm/symbols.cc
index b7d8bcff62f0c81d06fa9c3610ef54da0bf16bac..04cd1cfca928dcb74ebda71bb2cc56fba8ca667c 100644
--- a/runtime/vm/symbols.cc
+++ b/runtime/vm/symbols.cc
@@ -55,7 +55,7 @@ void Symbols::InitOnce(Isolate* isolate) {
}
Object::RegisterSingletonClassNames();
- for (uint32_t c = 0; c <= kMaxOneCharCodeSymbol; c++) {
+ for (int32_t c = 0; c <= kMaxOneCharCodeSymbol; c++) {
ASSERT(kMaxPredefinedId + c < kMaxId);
predefined_[kMaxPredefinedId + c] = New(&c, 1);
}
@@ -152,7 +152,7 @@ RawString* Symbols::New(const T* characters, intptr_t len) {
template RawString* Symbols::New(const uint8_t* characters, intptr_t len);
template RawString* Symbols::New(const uint16_t* characters, intptr_t len);
-template RawString* Symbols::New(const uint32_t* characters, intptr_t len);
+template RawString* Symbols::New(const int32_t* characters, intptr_t len);
RawString* Symbols::New(const String& str) {
@@ -204,7 +204,7 @@ RawString* Symbols::New(const String& str, intptr_t begin_index, intptr_t len) {
}
-RawString* Symbols::FromCharCode(uint32_t char_code) {
+RawString* Symbols::FromCharCode(int32_t char_code) {
if (char_code > kMaxOneCharCodeSymbol) {
return New(&char_code, 1);
}
@@ -289,7 +289,7 @@ template intptr_t Symbols::FindIndex(const Array& symbol_table,
intptr_t len,
intptr_t hash);
template intptr_t Symbols::FindIndex(const Array& symbol_table,
- const uint32_t* characters,
+ const int32_t* characters,
intptr_t len,
intptr_t hash);
« no previous file with comments | « runtime/vm/symbols.h ('k') | runtime/vm/unicode.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698