runtime/vm/unicode.h - Issue 11419086: Use a signed 32-bit integer for representing code points.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/unicode.h

Issue 11419086: Use a signed 32-bit integer for representing code points. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: add missing files Created 8 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/unicode.h

diff --git a/runtime/vm/unicode.h b/runtime/vm/unicode.h

index 2cb23c04511cbb969a36ea57b367a46a12868811..fdb755d0f96eea81aa41d63a6248af3ca86e964b 100644

--- a/runtime/vm/unicode.h

+++ b/runtime/vm/unicode.h

@@ -52,10 +52,10 @@ class Utf8 : AllStatic {

intptr_t len);

static bool DecodeToUTF32(const uint8_t* utf8_array,

intptr_t array_len,

- uint32_t* dst,

+ int32_t* dst,

intptr_t len);

static bool DecodeCStringToUTF32(const char* str,

- uint32_t* dst,

+ int32_t* dst,

intptr_t len) {

ASSERT(str != NULL);

intptr_t array_len = strlen(str);

« no previous file with comments | « runtime/vm/symbols.cc ('k') | runtime/vm/unicode.cc » ('j') | no next file with comments »