Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Issue 1140263005: Revert "Hide Isolate pointer from embedder" (Closed)

Created:
5 years, 7 months ago by Cutch
Modified:
5 years, 7 months ago
Reviewers:
turnidge
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Revert "Hide Isolate pointer from embedder" This reverts commit 014e694ba7a7f75f2e7094b77c9c97b93a0116c1. Revert "Fix fall out from hide isolate pointer change" This reverts commit 966aafbc8155184868499e51ae479a9401a9d08e. Revert "Fix build" This reverts commit d7b03ba7b0bfc459effa52f1da4a706ace402b93. BUG= Committed: https://github.com/dart-lang/sdk/commit/51d8bae199a6c0c384ca2b56358efeee68b4a136

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+160 lines, -224 lines) Patch
M runtime/bin/builtin.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/builtin_common.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/builtin_nolib.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dartutils.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/dbg_connection.cc View 1 chunk +1 line, -2 lines 0 comments Download
M runtime/bin/dbg_message.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/bin/gen_snapshot.cc View 5 chunks +5 lines, -6 lines 0 comments Download
M runtime/bin/io_service.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/bin/main.cc View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/bin/vmservice_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/include/dart_api.h View 8 chunks +18 lines, -41 lines 0 comments Download
M runtime/include/dart_debugger_api.h View 3 chunks +4 lines, -4 lines 0 comments Download
M runtime/include/dart_native_api.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/lib/isolate.cc View 1 chunk +6 lines, -5 lines 0 comments Download
M runtime/platform/globals.h View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/benchmark_test.h View 2 chunks +2 lines, -3 lines 0 comments Download
M runtime/vm/custom_isolate_test.cc View 6 chunks +8 lines, -9 lines 0 comments Download
M runtime/vm/dart_api_impl.h View 1 chunk +0 lines, -2 lines 0 comments Download
M runtime/vm/dart_api_impl.cc View 1 8 chunks +22 lines, -34 lines 0 comments Download
M runtime/vm/dart_api_impl_test.cc View 12 chunks +20 lines, -27 lines 0 comments Download
M runtime/vm/debugger.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/debugger_api_impl.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M runtime/vm/debugger_api_impl_test.cc View 9 chunks +14 lines, -14 lines 0 comments Download
M runtime/vm/isolate.h View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/isolate.cc View 2 chunks +1 line, -16 lines 0 comments Download
M runtime/vm/json_stream.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M runtime/vm/native_api_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/object.cc View 1 2 chunks +2 lines, -2 lines 0 comments Download
M runtime/vm/port.h View 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/port.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M runtime/vm/service_isolate.cc View 9 chunks +16 lines, -15 lines 0 comments Download
M runtime/vm/unit_test.h View 3 chunks +7 lines, -8 lines 0 comments Download
M samples/sample_extension/sample_extension.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 7 months ago (2015-05-19 12:47:30 UTC) #2
Cutch
TBR
5 years, 7 months ago (2015-05-19 18:41:44 UTC) #4
Cutch
5 years, 7 months ago (2015-05-19 18:41:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
51d8bae199a6c0c384ca2b56358efeee68b4a136 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698