runtime/vm/native_api_impl.cc - Issue 1140263005: Revert "Hide Isolate pointer from embedder"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/native_api_impl.cc

Issue 1140263005: Revert "Hide Isolate pointer from embedder" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/native_api_impl.cc

diff --git a/runtime/vm/native_api_impl.cc b/runtime/vm/native_api_impl.cc

index db22e37a54115b51c85b7e2e8cf52e9cb1557277..a3cd5c1a702822a7335e8989fb22987a10243da5 100644

--- a/runtime/vm/native_api_impl.cc

+++ b/runtime/vm/native_api_impl.cc

@@ -44,7 +44,7 @@ DART_EXPORT Dart_Port Dart_NewNativePort(const char* name,

if (handler == NULL) {

OS::PrintErr("%s expects argument 'handler' to be non-null.\n",

CURRENT_FUNC);

- return DART_ILLEGAL_PORT;

+ return ILLEGAL_PORT;

}

// Start the native port without a current isolate.

IsolateSaver saver(Isolate::Current());

« no previous file with comments | « runtime/vm/json_stream.cc ('k') | runtime/vm/object.cc » ('j') | no next file with comments »