runtime/bin/vmservice_impl.cc - Issue 1140263005: Revert "Hide Isolate pointer from embedder"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/vmservice_impl.cc

Issue 1140263005: Revert "Hide Isolate pointer from embedder" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/vmservice_impl.cc

diff --git a/runtime/bin/vmservice_impl.cc b/runtime/bin/vmservice_impl.cc

index 041cbde658193aaf41afeee297120964d53b0c17..e830389416c1917a95de66b8e8eec78e6bd92882 100644

--- a/runtime/bin/vmservice_impl.cc

+++ b/runtime/bin/vmservice_impl.cc

@@ -161,7 +161,7 @@ intptr_t VmService::server_port_ = 0;

bool VmService::Setup(const char* server_ip, intptr_t server_port) {

Dart_Isolate isolate = Dart_CurrentIsolate();

- ASSERT(isolate != DART_ILLEGAL_ISOLATE);

+ ASSERT(isolate != NULL);

SetServerIPAndPort("", 0);

Dart_Handle result;

« no previous file with comments | « runtime/bin/main.cc ('k') | runtime/include/dart_api.h » ('j') | no next file with comments »