Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(550)

Unified Diff: runtime/bin/dbg_connection.cc

Issue 1140263005: Revert "Hide Isolate pointer from embedder" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/bin/dbg_message.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/dbg_connection.cc
diff --git a/runtime/bin/dbg_connection.cc b/runtime/bin/dbg_connection.cc
index e6489df62f064e37676dfb124c430eb1f1d15f66..2cc4cd83ffa761e4bc780f45c94c038b0980486a 100644
--- a/runtime/bin/dbg_connection.cc
+++ b/runtime/bin/dbg_connection.cc
@@ -455,8 +455,7 @@ void DebuggerConnectionHandler::HandleInterruptCmd(DbgMessage* in_msg) {
MessageParser msg_parser(in_msg->buffer(), in_msg->buffer_len());
int msg_id = msg_parser.MessageId();
Dart_IsolateId isolate_id = msg_parser.GetInt64Param("isolateId");
- if (isolate_id == DART_ILLEGAL_ISOLATE_ID ||
- Dart_GetIsolate(isolate_id) == DART_ILLEGAL_ISOLATE) {
+ if (isolate_id == ILLEGAL_ISOLATE_ID || Dart_GetIsolate(isolate_id) == NULL) {
in_msg->SendErrorReply(msg_id, "Invalid isolate specified");
return;
}
« no previous file with comments | « runtime/bin/dartutils.cc ('k') | runtime/bin/dbg_message.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698