runtime/bin/builtin_common.cc - Issue 1140263005: Revert "Hide Isolate pointer from embedder"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/bin/builtin_common.cc

Issue 1140263005: Revert "Hide Isolate pointer from embedder" (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/bin/builtin_common.cc

diff --git a/runtime/bin/builtin_common.cc b/runtime/bin/builtin_common.cc

index e727246dad06786ce23c75dce996a69e4b66d7c5..da754a5222d0d4842e7764b36fc5848f0c3be614 100644

--- a/runtime/bin/builtin_common.cc

+++ b/runtime/bin/builtin_common.cc

@@ -15,7 +15,7 @@ namespace bin {

void Builtin::SetLoadPort(Dart_Port port) {

load_port_ = port;

- ASSERT(load_port_ != DART_ILLEGAL_PORT);

+ ASSERT(load_port_ != ILLEGAL_PORT);

Dart_Handle field_name = DartUtils::NewString("_loadPort");

ASSERT(!Dart_IsError(field_name));

Dart_Handle builtin_lib =

« no previous file with comments | « runtime/bin/builtin.cc ('k') | runtime/bin/builtin_nolib.cc » ('j') | no next file with comments »