Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(198)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1112563002: Refactor SsaBuilder.visitStaticSend and visitGetterSend. (Closed)

Created:
5 years, 7 months ago by Johnni Winther
Modified:
5 years, 7 months ago
Reviewers:
karlklose
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

Refactor SsaBuilder.visitStaticSend and visitGetterSend. BUG= R=karlklose@google.com Committed: https://code.google.com/p/dart/source/detail?r=45449

Patch Set 1 #

Patch Set 2 : Add tests. #

Total comments: 4

Patch Set 3 : Updated cf. comments. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+580 lines, -201 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 3 chunks +29 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 4 chunks +32 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 12 chunks +91 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 chunk +11 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 4 chunks +17 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 8 chunks +306 lines, -139 lines 0 comments Download
M tests/compiler/dart2js/compiler_helper.dart View 1 chunk +1 line, -0 lines 0 comments Download
M tests/compiler/dart2js/load_elimination_test.dart View 2 chunks +27 lines, -22 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 1 10 chunks +64 lines, -6 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Johnni Winther
5 years, 7 months ago (2015-04-28 13:31:23 UTC) #2
Johnni Winther
ping
5 years, 7 months ago (2015-04-29 10:36:11 UTC) #3
karlklose
LGTM. https://codereview.chromium.org/1112563002/diff/20001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1112563002/diff/20001/pkg/compiler/lib/src/ssa/builder.dart#newcode3253 pkg/compiler/lib/src/ssa/builder.dart:3253: stack.add(graph.addConstantNull(compiler)); Please add a comment on what this ...
5 years, 7 months ago (2015-04-29 10:54:23 UTC) #4
Johnni Winther
https://codereview.chromium.org/1112563002/diff/20001/pkg/compiler/lib/src/ssa/builder.dart File pkg/compiler/lib/src/ssa/builder.dart (right): https://codereview.chromium.org/1112563002/diff/20001/pkg/compiler/lib/src/ssa/builder.dart#newcode3253 pkg/compiler/lib/src/ssa/builder.dart:3253: stack.add(graph.addConstantNull(compiler)); On 2015/04/29 10:54:23, karlklose wrote: > Please add ...
5 years, 7 months ago (2015-04-29 11:38:09 UTC) #5
Johnni Winther
5 years, 7 months ago (2015-04-29 11:44:55 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as 45449 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698