Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(25)

Unified Diff: pkg/compiler/lib/src/resolution/semantic_visitor.dart

Issue 1112563002: Refactor SsaBuilder.visitStaticSend and visitGetterSend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/semantic_visitor.dart
diff --git a/pkg/compiler/lib/src/resolution/semantic_visitor.dart b/pkg/compiler/lib/src/resolution/semantic_visitor.dart
index cc4b345903474a568a084f6eaa7f703fecb0f4b8..b626bba589838d6e7b5293cbdb5e34faa5d858ed 100644
--- a/pkg/compiler/lib/src/resolution/semantic_visitor.dart
+++ b/pkg/compiler/lib/src/resolution/semantic_visitor.dart
@@ -737,6 +737,21 @@ abstract class SemanticSendVisitor<R, A> {
CallStructure callStructure,
A arg);
+ /// Invocation of the static [function] with incompatible [arguments].
+ ///
+ /// For instance
+ /// class C {
+ /// static foo(a, b) {}
+ /// }
+ /// m() { C.foo(null); }
+ ///
+ R visitStaticFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg);
+
/// Assignment of [rhs] to the static [function].
///
/// For instance
@@ -907,6 +922,21 @@ abstract class SemanticSendVisitor<R, A> {
CallStructure callStructure,
A arg);
+ /// Invocation of the top level [function] with incompatible [arguments].
+ ///
+ /// For instance
+ /// class C {
+ /// static foo(a, b) {}
+ /// }
+ /// m() { C.foo(null); }
+ ///
+ R visitTopLevelFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg);
+
/// Assignment of [rhs] to the top level [function].
///
/// For instance
@@ -2682,7 +2712,7 @@ abstract class SemanticSendVisitor<R, A> {
/// m7() => prefix.C.unresolved;
///
// TODO(johnniwinther): Split the cases in which a prefix is resolved.
- R errorUnresolvedGet(
+ R visitUnresolvedGet(
Send node,
Element element,
A arg);
@@ -2732,7 +2762,7 @@ abstract class SemanticSendVisitor<R, A> {
/// m7() => prefix.C.unresolved(null, 42);
///
// TODO(johnniwinther): Split the cases in which a prefix is resolved.
- R errorUnresolvedInvoke(
+ R visitUnresolvedInvoke(
Send node,
Element element,
NodeList arguments,
« no previous file with comments | « pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart ('k') | pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698