Refactor SsaBuilder.visitStaticSend and visitGetterSend.

pkg/compiler/lib/src/resolution/semantic_visitor.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.semantics_visitor;
 
 import '../constants/expressions.dart';
 import '../dart2jslib.dart' show invariant;
 import '../dart_types.dart';
 import '../elements/elements.dart';
@@ skipping 719 matching lines @@
   ///     }
   ///     m() { C.foo(null, 42); }
   ///
   R visitStaticFunctionInvoke(
       Send node,
       MethodElement function,
       NodeList arguments,
       CallStructure callStructure,
       A arg);
 
+  /// Invocation of the static [function] with incompatible [arguments].
+  ///
+  /// For instance
+  ///     class C {
+  ///       static foo(a, b) {}
+  ///     }
+  ///     m() { C.foo(null); }
+  ///
+  R visitStaticFunctionIncompatibleInvoke(
+      Send node,
+      MethodElement function,
+      NodeList arguments,
+      CallStructure callStructure,
+      A arg);
+
   /// Assignment of [rhs] to the static [function].
   ///
   /// For instance
   ///     class C {
   ///       static foo(a, b) {}
   ///     }
   ///     m() { C.foo = rhs; }
   ///
   R errorStaticFunctionSet(
       Send node,
@@ skipping 150 matching lines @@
   ///     foo(a, b) {};
   ///     m() { foo(null, 42); }
   ///
   R visitTopLevelFunctionInvoke(
       Send node,
       MethodElement function,
       NodeList arguments,
       CallStructure callStructure,
       A arg);
 
+  /// Invocation of the top level [function] with incompatible [arguments].
+  ///
+  /// For instance
+  ///     class C {
+  ///       static foo(a, b) {}
+  ///     }
+  ///     m() { C.foo(null); }
+  ///
+  R visitTopLevelFunctionIncompatibleInvoke(
+      Send node,
+      MethodElement function,
+      NodeList arguments,
+      CallStructure callStructure,
+      A arg);
+
   /// Assignment of [rhs] to the top level [function].
   ///
   /// For instance
   ///     foo(a, b) {};
   ///     m() { foo = rhs; }
   ///
   R errorTopLevelFunctionSet(
       Send node,
       MethodElement function,
       Node rhs,
@@ skipping 1755 matching lines @@
   ///     class C {}
   ///     m1() => unresolved;
   ///     m2() => prefix.unresolved;
   ///     m3() => Unresolved.foo;
   ///     m4() => unresolved.foo;
   ///     m5() => unresolved.Foo.bar;
   ///     m6() => C.unresolved;
   ///     m7() => prefix.C.unresolved;
   ///
   // TODO(johnniwinther): Split the cases in which a prefix is resolved.
-  R errorUnresolvedGet(
+  R visitUnresolvedGet(
       Send node,
       Element element,
       A arg);
 
   /// Read of the unresolved super [element].
   ///
   /// For instance
   ///     class B {}
   ///     class C {
   ///       m() => super.foo;
@@ skipping 29 matching lines @@
   ///     class C {}
   ///     m1() => unresolved(null, 42);
   ///     m2() => prefix.unresolved(null, 42);
   ///     m3() => Unresolved.foo(null, 42);
   ///     m4() => unresolved.foo(null, 42);
   ///     m5() => unresolved.Foo.bar(null, 42);
   ///     m6() => C.unresolved(null, 42);
   ///     m7() => prefix.C.unresolved(null, 42);
   ///
   // TODO(johnniwinther): Split the cases in which a prefix is resolved.
-  R errorUnresolvedInvoke(
+  R visitUnresolvedInvoke(
       Send node,
       Element element,
       NodeList arguments,
       Selector selector,
       A arg);
 
   /// Invocation of the unresolved super [element] with [arguments].
   ///
   /// For instance
   ///     class B {}
@@ skipping 854 matching lines @@
   ///       C() : this._(42);
   ///     }
   ///
   R errorUnresolvedThisConstructorInvoke(
       Send node,
       Element element,
       NodeList arguments,
       Selector selector,
       A arg);
 }