Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Unified Diff: pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart

Issue 1112563002: Refactor SsaBuilder.visitStaticSend and visitGetterSend. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Updated cf. comments. Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart
diff --git a/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart b/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart
index b0c0472083ac9ee8fa9361a4e292fa62d88f3a5e..dce195b1b07de12a64b856ce9cdbb060245224bc 100644
--- a/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart
+++ b/pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart
@@ -465,24 +465,6 @@ abstract class ErrorBulkMixin<R, A>
}
@override
- R errorUnresolvedGet(
- Send node,
- Element element,
- A arg) {
- return bulkHandleError(node, arg);
- }
-
- @override
- R errorUnresolvedInvoke(
- Send node,
- Element element,
- NodeList arguments,
- Selector selector,
- A arg) {
- return bulkHandleError(node, arg);
- }
-
- @override
R errorUnresolvedPostfix(
Send node,
Element element,
@@ -1238,6 +1220,16 @@ abstract class InvokeBulkMixin<R, A>
}
@override
+ R visitStaticFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg) {
+ return bulkHandleInvoke(node, arg);
+ }
+
+ @override
R visitStaticGetterInvoke(
Send node,
FunctionElement getter,
@@ -1326,6 +1318,16 @@ abstract class InvokeBulkMixin<R, A>
}
@override
+ R visitTopLevelFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg) {
+ return bulkHandleInvoke(node, arg);
+ }
+
+ @override
R visitTopLevelGetterInvoke(
Send node,
FunctionElement getter,
@@ -1366,6 +1368,16 @@ abstract class InvokeBulkMixin<R, A>
}
@override
+ R visitUnresolvedInvoke(
+ Send node,
+ Element element,
+ NodeList arguments,
+ Selector selector,
+ A arg) {
+ return bulkHandleInvoke(node, arg);
+ }
+
+ @override
R visitUnresolvedSuperInvoke(
Send node,
Element function,
@@ -1547,6 +1559,14 @@ abstract class GetBulkMixin<R, A>
}
@override
+ R visitUnresolvedGet(
+ Send node,
+ Element element,
+ A arg) {
+ return bulkHandleGet(node, arg);
+ }
+
+ @override
R visitUnresolvedSuperGet(
Send node,
Element element,
@@ -3770,6 +3790,17 @@ class TraversalSendMixin<R, A> implements SemanticSendVisitor<R, A> {
}
@override
+ R visitStaticFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg) {
+ apply(arguments, arg);
+ return null;
+ }
+
+ @override
R visitStaticGetterGet(
Send node,
FunctionElement getter,
@@ -4355,6 +4386,17 @@ class TraversalSendMixin<R, A> implements SemanticSendVisitor<R, A> {
}
@override
+ R visitTopLevelFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg) {
+ apply(arguments, arg);
+ return null;
+ }
+
+ @override
R visitTopLevelGetterGet(
Send node,
FunctionElement getter,
@@ -4565,7 +4607,7 @@ class TraversalSendMixin<R, A> implements SemanticSendVisitor<R, A> {
}
@override
- R errorUnresolvedGet(
+ R visitUnresolvedGet(
Send node,
Element element,
A arg) {
@@ -4573,7 +4615,7 @@ class TraversalSendMixin<R, A> implements SemanticSendVisitor<R, A> {
}
@override
- R errorUnresolvedInvoke(
+ R visitUnresolvedInvoke(
Send node,
Element element,
NodeList arguments,
@@ -5377,6 +5419,13 @@ abstract class BaseImplementationOfStaticsMixin<R, A>
CallStructure callStructure,
A arg);
+ R handleStaticFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg);
+
R handleStaticGetterGet(
Send node,
FunctionElement getter,
@@ -5504,6 +5553,17 @@ abstract class BaseImplementationOfStaticsMixin<R, A>
}
@override
+ R visitStaticFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg) {
+ return handleStaticFunctionIncompatibleInvoke(
+ node, function, arguments, callStructure, arg);
+ }
+
+ @override
R visitStaticGetterGet(
Send node,
FunctionElement getter,
@@ -5676,6 +5736,17 @@ abstract class BaseImplementationOfStaticsMixin<R, A>
}
@override
+ R visitTopLevelFunctionIncompatibleInvoke(
+ Send node,
+ MethodElement function,
+ NodeList arguments,
+ CallStructure callStructure,
+ A arg) {
+ return handleStaticFunctionIncompatibleInvoke(
+ node, function, arguments, callStructure, arg);
+ }
+
+ @override
R visitTopLevelGetterGet(
Send node,
FunctionElement getter,
« no previous file with comments | « pkg/compiler/lib/src/resolution/semantic_visitor.dart ('k') | pkg/compiler/lib/src/resolution/send_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698