Refactor SsaBuilder.visitStaticSend and visitGetterSend.

tests/compiler/dart2js/semantic_visitor_test.dart

 // Copyright (c) 2015, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library dart2js.semantics_visitor_test;
 
 import 'dart:async';
 import 'package:async_helper/async_helper.dart';
 import 'package:expect/expect.dart';
 import 'package:compiler/src/constants/expressions.dart';
@@ skipping 487 matching lines @@
     const Test.prefix(
         '''
         class C {
           static o(a, b) {}
         }
         ''',
         'm() { p.C.o(null, 42); }',
         const Visit(VisitKind.VISIT_STATIC_FUNCTION_INVOKE,
                     element: 'function(C#o)',
                     arguments: '(null,42)')),
+    const Test(
+        '''
+        class C { static o(a, b) {} }
+        m() => C.o(null);
+        ''',
+        const Visit(VisitKind.VISIT_STATIC_FUNCTION_INCOMPATIBLE_INVOKE,
+                    element: 'function(C#o)',
+                    arguments: '(null)')),
   ],
   'Top level fields': const [
     // Top level fields
     const Test(
         '''
         var o;
         m() => o;
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_FIELD_GET,
                     element: 'field(o)')),
@@ skipping 29 matching lines @@
                     element: 'field(o)',
                     arguments: '(null,42)')),
     const Test.prefix(
         '''
         var o;
         ''',
         'm() { p.o(null, 42); }',
         const Visit(VisitKind.VISIT_TOP_LEVEL_FIELD_INVOKE,
                     element: 'field(o)',
                     arguments: '(null,42)')),
+    const Test(
+        '''
+        m() => o;
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_GET,
+                    name: 'o')),
   ],
   'Top level properties': const [
     // Top level properties
     const Test(
         '''
         get o => null;
         m() => o;
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_GET,
                     element: 'getter(o)')),
@@ skipping 49 matching lines @@
         const Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_GET,
                     element: 'function(o)')),
     const Test(
         '''
         o(a, b) {}
         m() => o(null, 42);
         ''',
         const Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_INVOKE,
                     element: 'function(o)',
                     arguments: '(null,42)')),
+    const Test(
+        '''
+        o(a, b) {}
+        m() => o(null);
+        ''',
+        const Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_INCOMPATIBLE_INVOKE,
+                    element: 'function(o)',
+                    arguments: '(null)')),
     const Test.prefix(
         '''
         o(a, b) {}
         ''',
         'm() { p.o(null, 42); }',
         const Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_INVOKE,
                     element: 'function(o)',
                     arguments: '(null,42)')),
+    const Test(
+        '''
+        m() => o(null, 42);
+        ''',
+        const Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
+                    name: 'o',
+                    arguments: '(null,42)')),
   ],
   'Dynamic properties': const [
     // Dynamic properties
     const Test('m(o) => o.foo;',
         const [
           const Visit(VisitKind.VISIT_DYNAMIC_PROPERTY_GET,
                       receiver: 'o',
                       name: 'foo'),
           const Visit(VisitKind.VISIT_PARAMETER_GET,
                       element: 'parameter(m#o)'),
@@ skipping 2990 matching lines @@
       MethodElement function,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_FUNCTION_INVOKE,
         element: function, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
+  visitStaticFunctionIncompatibleInvoke(
+      Send node,
+      MethodElement function,
+      NodeList arguments,
+      CallStructure callStructure,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_STATIC_FUNCTION_INCOMPATIBLE_INVOKE,
+        element: function, arguments: arguments));
+    apply(arguments, arg);
+  }
+
+  @override
   visitStaticGetterGet(
       Send node,
       FunctionElement getter,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_STATIC_GETTER_GET,
         element: getter));
   }
 
   @override
   visitStaticGetterInvoke(
@@ skipping 168 matching lines @@
       MethodElement function,
       NodeList arguments,
       CallStructure callStructure,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_INVOKE,
         element: function, arguments: arguments));
     apply(arguments, arg);
   }
 
   @override
+  visitTopLevelFunctionIncompatibleInvoke(
+      Send node,
+      MethodElement function,
+      NodeList arguments,
+      CallStructure callStructure,
+      arg) {
+    visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_FUNCTION_INCOMPATIBLE_INVOKE,
+        element: function, arguments: arguments));
+    apply(arguments, arg);
+  }
+
+  @override
   visitTopLevelGetterGet(
       Send node,
       FunctionElement getter,
       arg) {
     visits.add(new Visit(VisitKind.VISIT_TOP_LEVEL_GETTER_GET,
         element: getter));
   }
 
   @override
   visitTopLevelGetterInvoke(
@@ skipping 1216 matching lines @@
   errorUnresolvedCompound(
       Send node,
       ErroneousElement element,
       AssignmentOperator operator,
       Node rhs,
       arg) {
     // TODO: implement errorUnresolvedCompound
   }
 
   @override
-  errorUnresolvedGet(
+  visitUnresolvedGet(
       Send node,
-      ErroneousElement element,
+      Element element,
       arg) {
-    // TODO: implement errorUnresolvedGet
+    visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_GET, name: element.name));
   }
 
   @override
-  errorUnresolvedInvoke(
+  visitUnresolvedInvoke(
       Send node,
-      ErroneousElement element,
+      Element element,
       NodeList arguments,
       Selector selector,
       arg) {
-    // TODO: implement errorUnresolvedInvoke
+    visits.add(new Visit(VisitKind.VISIT_UNRESOLVED_INVOKE,
+        name: element.name, arguments: arguments));
   }
 
   @override
   errorUnresolvedPostfix(
       Send node,
       ErroneousElement element,
       IncDecOperator operator,
       arg) {
     visits.add(new Visit(
         VisitKind.ERROR_UNRESOLVED_POSTFIX, operator: operator));
@@ skipping 936 matching lines @@
   VISIT_STATIC_GETTER_INVOKE,
   VISIT_STATIC_GETTER_SETTER_COMPOUND,
   VISIT_STATIC_METHOD_SETTER_COMPOUND,
   VISIT_STATIC_GETTER_SETTER_PREFIX,
   VISIT_STATIC_GETTER_SETTER_POSTFIX,
   VISIT_STATIC_GETTER_DECL,
   VISIT_STATIC_SETTER_DECL,
 
   VISIT_STATIC_FUNCTION_GET,
   VISIT_STATIC_FUNCTION_INVOKE,
+  VISIT_STATIC_FUNCTION_INCOMPATIBLE_INVOKE,
   VISIT_STATIC_FUNCTION_DECL,
 
   VISIT_TOP_LEVEL_FIELD_GET,
   VISIT_TOP_LEVEL_FIELD_SET,
   VISIT_TOP_LEVEL_FIELD_INVOKE,
   VISIT_TOP_LEVEL_FIELD_COMPOUND,
   VISIT_TOP_LEVEL_FIELD_PREFIX,
   VISIT_TOP_LEVEL_FIELD_POSTFIX,
   VISIT_TOP_LEVEL_FIELD_DECL,
   VISIT_TOP_LEVEL_CONSTANT_DECL,
 
   VISIT_TOP_LEVEL_GETTER_GET,
   VISIT_TOP_LEVEL_SETTER_SET,
   VISIT_TOP_LEVEL_GETTER_INVOKE,
   VISIT_TOP_LEVEL_GETTER_SETTER_COMPOUND,
   VISIT_TOP_LEVEL_GETTER_SETTER_PREFIX,
   VISIT_TOP_LEVEL_GETTER_SETTER_POSTFIX,
   VISIT_TOP_LEVEL_GETTER_DECL,
   VISIT_TOP_LEVEL_SETTER_DECL,
 
   VISIT_TOP_LEVEL_FUNCTION_GET,
   VISIT_TOP_LEVEL_FUNCTION_INVOKE,
+  VISIT_TOP_LEVEL_FUNCTION_INCOMPATIBLE_INVOKE,
   VISIT_TOP_LEVEL_FUNCTION_DECL,
 
   VISIT_DYNAMIC_PROPERTY_GET,
   VISIT_DYNAMIC_PROPERTY_SET,
   VISIT_DYNAMIC_PROPERTY_INVOKE,
   VISIT_DYNAMIC_PROPERTY_COMPOUND,
   VISIT_DYNAMIC_PROPERTY_PREFIX,
   VISIT_DYNAMIC_PROPERTY_POSTFIX,
 
   VISIT_THIS_GET,
@@ skipping 23 matching lines @@
   VISIT_SUPER_GETTER_FIELD_PREFIX,
   VISIT_SUPER_FIELD_SETTER_PREFIX,
   VISIT_SUPER_GETTER_SETTER_POSTFIX,
   VISIT_SUPER_GETTER_FIELD_POSTFIX,
   VISIT_SUPER_FIELD_SETTER_POSTFIX,
 
   VISIT_SUPER_METHOD_GET,
   VISIT_SUPER_METHOD_INVOKE,
   VISIT_SUPER_METHOD_INCOMPATIBLE_INVOKE,
 
+  VISIT_UNRESOLVED_GET,
+  VISIT_UNRESOLVED_INVOKE,
   VISIT_UNRESOLVED_SUPER_GET,
   VISIT_UNRESOLVED_SUPER_INVOKE,
 
   VISIT_BINARY,
   VISIT_INDEX,
   VISIT_EQUALS,
   VISIT_NOT_EQUALS,
   VISIT_INDEX_PREFIX,
   VISIT_INDEX_POSTFIX,
 
@@ skipping 89 matching lines @@
   VISIT_OPTIONAL_PARAMETER_DECL,
   VISIT_NAMED_PARAMETER_DECL,
   VISIT_REQUIRED_INITIALIZING_FORMAL_DECL,
   VISIT_OPTIONAL_INITIALIZING_FORMAL_DECL,
   VISIT_NAMED_INITIALIZING_FORMAL_DECL,
 
   ERROR_UNRESOLVED_POSTFIX,
 
   // TODO(johnniwinther): Add tests for more error cases.
 }